[ObjC ARC] Converts ios/web:ios_web_web_state_ui_unittests to ARC.

ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/ui/wk_back_forward_list_item_holder.h"
 
 #import <WebKit/WebKit.h>
 
 #import "ios/web/navigation/navigation_item_impl.h"
 #import "ios/web/public/navigation_item.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "testing/gtest_mac.h"
 #include "testing/platform_test.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace web {
 
 // Test fixture for WKBackForwardListItemHolder class.
 typedef PlatformTest WKBackForwardListItemHolderTest;
 
 // Tests that FromNavigationItem returns the same holder for the same
 // NavigationItem.
 TEST_F(WKBackForwardListItemHolderTest, GetHolderFromNavigationItem) {
   std::unique_ptr<web::NavigationItem> item(NavigationItem::Create());
   WKBackForwardListItemHolder* holder1 =
@@ skipping 18 matching lines @@
       WKBackForwardListItemHolder::FromNavigationItem(item2.get());
   EXPECT_NE(holder1, holder2);
 }
 
 // Tests that acessors for the WKBackForwardListItem object work as
 // expected. The test bellow uses NSObject instead of WKBackForwardListItem
 // because WKBackForwardListItem alloc/release is not designed to be called
 // directly and will crash.
 TEST_F(WKBackForwardListItemHolderTest, GetBackForwardListItemFromHolder) {
   std::unique_ptr<web::NavigationItem> item(NavigationItem::Create());
-  base::scoped_nsobject<NSObject> input([[NSObject alloc] init]);
+  NSObject* input = [[NSObject alloc] init];
   WKBackForwardListItemHolder* holder =
       WKBackForwardListItemHolder::FromNavigationItem(item.get());
   holder->set_back_forward_list_item(
-      static_cast<WKBackForwardListItem*>(input.get()));
+      static_cast<WKBackForwardListItem*>(input));
   NSObject* result = holder->back_forward_list_item();
   EXPECT_EQ(input, result);
 }
 
 // Tests that acessors for navigation type work as expected.
 TEST_F(WKBackForwardListItemHolderTest, GetNavigationTypeFromHolder) {
   std::unique_ptr<web::NavigationItem> item(NavigationItem::Create());
   WKBackForwardListItemHolder* holder =
       WKBackForwardListItemHolder::FromNavigationItem(item.get());
 
@@ skipping 27 matching lines @@
   holder->set_navigation_type(type);
   EXPECT_EQ(type, holder->navigation_type());
 
   // Verify that setting 'WKNavigationTypeLinkActivated' means
   // |navigation_type| returns 'WKNavigationTypeLinkActivated'
   type = WKNavigationTypeLinkActivated;
   holder->set_navigation_type(type);
   EXPECT_EQ(type, holder->navigation_type());
 }
 
-// Tests that |back_forward_list_item| returns nil if the internal
-// WKBackForwardListItem was deallocated. The test bellow uses NSObject
-// instead of WKBackForwardListItem because WKBackForwardListItem alloc/
-// release is not designed to be called directly and will crash.
-TEST_F(WKBackForwardListItemHolderTest, GetNilBackForwardListItemFromHolder) {

[Eugene But (OOO till 7-30), 2017/06/14 13:42:20]

Sad.

[marq (ping after 24h), 2017/06/14 14:19:02]

Sad that the test was removed, or that it was there in the first place?

[Eugene But (OOO till 7-30), 2017/06/14 14:25:53]

That it was removed :)
I guess you think it was sad that test existed in the first place.

-  std::unique_ptr<web::NavigationItem> item(NavigationItem::Create());
-  WKBackForwardListItemHolder* holder =
-      WKBackForwardListItemHolder::FromNavigationItem(item.get());
-
-  // Add a WKBackForwardListItem and verify that |back_forward_list_item|
-  // returns does not return nil.
-  base::scoped_nsobject<NSObject> input([[NSObject alloc] init]);
-  holder->set_back_forward_list_item(
-      static_cast<WKBackForwardListItem*>(input.get()));
-  NSObject* result = holder->back_forward_list_item();
-  EXPECT_NE(nil, result);
-
-  // Deallocate the WKBackForwardListItem and verify that
-  // |back_forward_list_item| returns nil.
-  input.reset();
-  result = holder->back_forward_list_item();
-  EXPECT_EQ(nil, result);
-}
-
 }  // namespace web