Use OnceCallback for Mojo binding connection error handlers.

Use OnceCallback for Mojo binding connection error handlers.

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests

Review-Url: https://codereview.chromium.org/2932193002
Cr-Commit-Position: refs/heads/master@{#478798}
Committed: https://chromium.googlesource.com/chromium/src/+/14ae013de771be3f72bc59c407e0d677bbc093d8

[jameswest, 2017-06-10 02:06:10]

Description was changed from

==========
Use OnceCallback for Mojo binding connection error handlers.

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests
==========

to

==========
Use OnceCallback for Mojo binding connection error handlers.

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests
==========

[jameswest, 2017-06-10 02:06:10]

jameswest@google.com changed reviewers:
+ alokp@chromium.org, rockot@chromium.org

[Ken Rockot(use gerrit already), 2017-06-12 15:18:10]

rockot@chromium.org changed reviewers:
+ yzshen@chromium.org

[Ken Rockot(use gerrit already), 2017-06-12 15:18:10]

LG to me, but please allow yzshen@ to review too. Thanks!

[yzshen1, 2017-06-12 17:19:37]

On 2017/06/12 15:18:10, Ken Rockot(use gerrit already) wrote:
> LG to me, but please allow yzshen@ to review too. Thanks!

It looks reasonable to me.

I think it would need some changes across the codebase to update the user code.
Would you please also include that in the CL?
If you want to do that in follow-up CLs, you will need to keep both modes for a
short period of time before you convert all user code.

[alokp, 2017-06-12 17:22:14]

lgtm

[jameswest, 2017-06-12 19:24:51]

On 2017/06/12 17:19:37, yzshen1 wrote:
> On 2017/06/12 15:18:10, Ken Rockot(use gerrit already) wrote:
> > LG to me, but please allow yzshen@ to review too. Thanks!
> 
> It looks reasonable to me.
> 
> I think it would need some changes across the codebase to update the user
code.
> Would you please also include that in the CL?
> If you want to do that in follow-up CLs, you will need to keep both modes for
a
> short period of time before you convert all user code.

Do you mean update the user code to pass base::OnceCallback?
base::RepeatingCallback is implicitly cast to base::OnceCallback, so all
existing user code passing base::RepeatingCallback should continue to work
without any changes.

[yzshen1, 2017-06-12 19:37:31]

On 2017/06/12 19:24:51, jameswest wrote:
> On 2017/06/12 17:19:37, yzshen1 wrote:
> > On 2017/06/12 15:18:10, Ken Rockot(use gerrit already) wrote:
> > > LG to me, but please allow yzshen@ to review too. Thanks!
> > 
> > It looks reasonable to me.
> > 
> > I think it would need some changes across the codebase to update the user
> code.
> > Would you please also include that in the CL?
> > If you want to do that in follow-up CLs, you will need to keep both modes
for
> a
> > short period of time before you convert all user code.
> 
> Do you mean update the user code to pass base::OnceCallback?
> base::RepeatingCallback is implicitly cast to base::OnceCallback, so all
> existing user code passing base::RepeatingCallback should continue to work
> without any changes.

Ah, good to know!

LGTM

[jameswest, 2017-06-12 20:52:11]

The CQ bit was checked by jameswest@google.com

[commit-bot: I haz the power, 2017-06-12 20:52:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:52:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497300731996660,
"parent_rev": "d3ec2cc58603cc0578e7f3f17ddba5ff768303a7", "commit_rev":
"14ae013de771be3f72bc59c407e0d677bbc093d8"}

[commit-bot: I haz the power, 2017-06-12 22:52:14]

Description was changed from

==========
Use OnceCallback for Mojo binding connection error handlers.

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests
==========

to

==========
Use OnceCallback for Mojo binding connection error handlers.

Use RepeatingCallback for BindingSet connection error handlers because
the error handlers can be called for each entry in the set.

BUG=NONE
TEST=mojo_public_bindings_unittests

Review-Url: https://codereview.chromium.org/2932193002
Cr-Commit-Position: refs/heads/master@{#478798}
Committed:
https://chromium.googlesource.com/chromium/src/+/14ae013de771be3f72bc59c407e0...
==========

[commit-bot: I haz the power, 2017-06-12 22:52:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/14ae013de771be3f72bc59c407e0...