Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: mojo/public/cpp/bindings/lib/connector.cc

Issue 2932193002: Use OnceCallback for Mojo binding connection error handlers. (Closed)
Patch Set: Call Run() on rvalue. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/connector.cc
diff --git a/mojo/public/cpp/bindings/lib/connector.cc b/mojo/public/cpp/bindings/lib/connector.cc
index 9eb458c91b8dcc1f1a3f03828a15e5658737e0c8..46051cb4c6c1ebb554d34a8ba8edaf2555547e34 100644
--- a/mojo/public/cpp/bindings/lib/connector.cc
+++ b/mojo/public/cpp/bindings/lib/connector.cc
@@ -5,7 +5,6 @@
#include "mojo/public/cpp/bindings/connector.h"
#include <stdint.h>
-#include <utility>
#include "base/bind.h"
#include "base/lazy_instance.h"
@@ -479,8 +478,8 @@ void Connector::HandleError(bool force_pipe_reset, bool force_async_handler) {
WaitToReadMore();
} else {
error_ = true;
- if (!connection_error_handler_.is_null())
- connection_error_handler_.Run();
+ if (connection_error_handler_)
+ std::move(connection_error_handler_).Run();
}
}
« no previous file with comments | « mojo/public/cpp/bindings/lib/binding_state.h ('k') | mojo/public/cpp/bindings/lib/interface_endpoint_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698