Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: mojo/public/cpp/bindings/interface_ptr.h

Issue 2932193002: Use OnceCallback for Mojo binding connection error handlers. (Closed)
Patch Set: Call Run() on rvalue. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/interface_ptr.h
diff --git a/mojo/public/cpp/bindings/interface_ptr.h b/mojo/public/cpp/bindings/interface_ptr.h
index 9262d13aa40122fa5031b7c74fd1daa626bf5875..2eb93684fe6080074f4064f3f43682d54acdda33 100644
--- a/mojo/public/cpp/bindings/interface_ptr.h
+++ b/mojo/public/cpp/bindings/interface_ptr.h
@@ -153,13 +153,14 @@ class InterfacePtr {
//
// This method may only be called after the InterfacePtr has been bound to a
// message pipe.
- void set_connection_error_handler(const base::Closure& error_handler) {
- internal_state_.set_connection_error_handler(error_handler);
+ void set_connection_error_handler(base::OnceClosure error_handler) {
+ internal_state_.set_connection_error_handler(std::move(error_handler));
}
void set_connection_error_with_reason_handler(
- const ConnectionErrorWithReasonCallback& error_handler) {
- internal_state_.set_connection_error_with_reason_handler(error_handler);
+ ConnectionErrorWithReasonCallback error_handler) {
+ internal_state_.set_connection_error_with_reason_handler(
+ std::move(error_handler));
}
// Unbinds the InterfacePtr and returns the information which could be used
« no previous file with comments | « mojo/public/cpp/bindings/interface_endpoint_client.h ('k') | mojo/public/cpp/bindings/lib/associated_binding.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698