Move libc++ configs and flags out of //build/config/sanitizers

Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

Additionally, there is a target, android_protoc, which has a
dependency on exe_and_shlib_deps but removes the
default_sanitizer_flags, which used to bring in c++flags.  This meant
the sources would compile against the libstdc++ headers in the
sysroot, but link against libc++, resulting in many symbol conflicts.

BUG=593874
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2931983003
Cr-Commit-Position: refs/heads/master@{#481392}
Committed: https://chromium.googlesource.com/chromium/src/+/018ffc7f6451b844d6f3f45e8d01ced35adeb780

[Tom Anderson, 2017-06-09 00:11:20]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[Tom Anderson, 2017-06-09 00:11:28]

brettw ptal

[commit-bot: I haz the power, 2017-06-09 00:12:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 00:14:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 00:14:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tom Anderson, 2017-06-09 00:33:54]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 00:34:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Anderson, 2017-06-09 00:46:11]

Patchset #1 (id:1) has been deleted

[Tom Anderson, 2017-06-09 00:46:15]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-06-09 02:07:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 02:07:38]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-06-12 17:55:18]

https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:522: "//build/config/libc++:libc++flags",
The reason things need to go here is that targets need to opt-out of them. Will
this need to happen? If this capability is not needed, it might be nice to
reference this from somewhere else like the "compiler" config.

https://codereview.chromium.org/2931983003/diff/40001/build/config/libc++/BUI...
File build/config/libc++/BUILD.gn (right):

https://codereview.chromium.org/2931983003/diff/40001/build/config/libc++/BUI...
build/config/libc++/BUILD.gn:1: import("//build/config/libc++/libc++.gni")
This file and the next one need the copyright header.

[Tom Anderson, 2017-06-16 20:49:50]

also renamed libc++flags to c++flags since it adds eg. -nostdinc++

https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:522: "//build/config/libc++:libc++flags",
On 2017/06/12 17:55:18, brettw wrote:
> The reason things need to go here is that targets need to opt-out of them.
Will
> this need to happen? If this capability is not needed, it might be nice to
> reference this from somewhere else like the "compiler" config.

I think (maybe) cronet needs to remove it so it can link against the system
libc++ instead

https://codereview.chromium.org/2931983003/diff/40001/build/config/libc++/BUI...
File build/config/libc++/BUILD.gn (right):

https://codereview.chromium.org/2931983003/diff/40001/build/config/libc++/BUI...
build/config/libc++/BUILD.gn:1: import("//build/config/libc++/libc++.gni")
On 2017/06/12 17:55:18, brettw wrote:
> This file and the next one need the copyright header.

Done.

[brettw, 2017-06-19 23:40:26]

https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:522: "//build/config/libc++:libc++flags",
Your current patch doesn't implement this. Since we also aren't sure if it will
be necessary, I think we should not be modifying the file and do the sub-config
solution I suggested. Chronet people can move it to here if they need it.

[Tom Anderson, 2017-06-21 16:28:37]

On 2017/06/19 23:40:26, brettw wrote:
>
https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
> File build/config/BUILDCONFIG.gn (right):
> 
>
https://codereview.chromium.org/2931983003/diff/40001/build/config/BUILDCONFI...
> build/config/BUILDCONFIG.gn:522: "//build/config/libc++:libc++flags",
> Your current patch doesn't implement this. Since we also aren't sure if it
will
> be necessary, I think we should not be modifying the file and do the
sub-config
> solution I suggested. Chronet people can move it to here if they need it.

Makes sense. Moved it out of BUILDCONFIG.gn and into //build/config/compiler in
the latest patch set

[Tom Anderson, 2017-06-21 16:37:24]

Description was changed from

==========
Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

BUG=593874
R=brettw@chromium.org
==========

to

==========
Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

Additionally, there is a target, android_protoc, which has a
dependency on exe_and_shlib_deps but removes the
default_sanitizer_flags, which used to bring in c++flags.  This meant
the sources would compile against the headers in the sysroot, but link
against libc++, resulting in many symbol conflicts.

BUG=593874
R=brettw@chromium.org
==========

[Tom Anderson, 2017-06-21 16:39:32]

Description was changed from

==========
Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

Additionally, there is a target, android_protoc, which has a
dependency on exe_and_shlib_deps but removes the
default_sanitizer_flags, which used to bring in c++flags.  This meant
the sources would compile against the headers in the sysroot, but link
against libc++, resulting in many symbol conflicts.

BUG=593874
R=brettw@chromium.org
==========

to

==========
Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

Additionally, there is a target, android_protoc, which has a
dependency on exe_and_shlib_deps but removes the
default_sanitizer_flags, which used to bring in c++flags.  This meant
the sources would compile against the libstdc++ headers in the
sysroot, but link against libc++, resulting in many symbol conflicts.

BUG=593874
R=brettw@chromium.org
==========

[brettw, 2017-06-21 22:31:00]

lgtm

[Tom Anderson, 2017-06-21 22:40:33]

The CQ bit was checked by thomasanderson@chromium.org

[commit-bot: I haz the power, 2017-06-21 22:40:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 22:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 22:50:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Anderson, 2017-06-21 22:53:03]

thomasanderson@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Anderson, 2017-06-21 22:53:04]

+thestig for extensions/shell/installer/linux/BUILD.gn

[Tom Anderson, 2017-06-21 22:53:15]

Patchset #4 (id:100001) has been deleted

[Lei Zhang, 2017-06-21 22:57:20]

On 2017/06/21 22:53:04, Tom Anderson wrote:
> +thestig for extensions/shell/installer/linux/BUILD.gn

lgtm, but I think you actually need extensions/shell/OWNERS for that.

[Tom Anderson, 2017-06-21 22:59:18]

On 2017/06/21 22:57:20, Lei Zhang wrote:
> On 2017/06/21 22:53:04, Tom Anderson wrote:
> > +thestig for extensions/shell/installer/linux/BUILD.gn
> 
> lgtm, but I think you actually need extensions/shell/OWNERS for that.

oops typo, I actually needed your approval for chrome/installer/linux/BUILD.gn

[Tom Anderson, 2017-06-21 23:03:58]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 23:04:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-06-21 23:26:50]

On 2017/06/21 22:59:18, Tom Anderson wrote:
> On 2017/06/21 22:57:20, Lei Zhang wrote:
> > On 2017/06/21 22:53:04, Tom Anderson wrote:
> > > +thestig for extensions/shell/installer/linux/BUILD.gn
> > 
> > lgtm, but I think you actually need extensions/shell/OWNERS for that.
> 
> oops typo, I actually needed your approval for chrome/installer/linux/BUILD.gn

Still lgtm since the change there is identical to the extensions/ change.

[commit-bot: I haz the power, 2017-06-22 01:09:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 01:09:02]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-06-22 01:12:19]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-06-22 01:12:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 01:25:35]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1498093939887880,
"parent_rev": "1ebf3cb1014b2c85d4520e6dcb6a11d7001bc30f", "commit_rev":
"018ffc7f6451b844d6f3f45e8d01ced35adeb780"}

[commit-bot: I haz the power, 2017-06-22 01:25:49]

Description was changed from

==========
Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

Additionally, there is a target, android_protoc, which has a
dependency on exe_and_shlib_deps but removes the
default_sanitizer_flags, which used to bring in c++flags.  This meant
the sources would compile against the libstdc++ headers in the
sysroot, but link against libc++, resulting in many symbol conflicts.

BUG=593874
R=brettw@chromium.org
==========

to

==========
Move libc++ configs and flags out of //build/config/sanitizers

libc++ used to be used only on instrumented builds, so it made sense
for the associated build code to go in //build/config/sanitizers.  Now
that non-sanitizer builds are switching to libc++ as well, it makes
more sense for this code to live elsewhere.

Additionally, there is a target, android_protoc, which has a
dependency on exe_and_shlib_deps but removes the
default_sanitizer_flags, which used to bring in c++flags.  This meant
the sources would compile against the libstdc++ headers in the
sysroot, but link against libc++, resulting in many symbol conflicts.

BUG=593874
R=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2931983003
Cr-Commit-Position: refs/heads/master@{#481392}
Committed:
https://chromium.googlesource.com/chromium/src/+/018ffc7f6451b844d6f3f45e8d01...
==========

[commit-bot: I haz the power, 2017-06-22 01:25:50]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/018ffc7f6451b844d6f3f45e8d01...