Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: build/config/BUILDCONFIG.gn

Issue 2931983003: Move libc++ configs and flags out of //build/config/sanitizers (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================================================= 5 # =============================================================================
6 # WHAT IS THIS FILE? 6 # WHAT IS THIS FILE?
7 # ============================================================================= 7 # =============================================================================
8 # 8 #
9 # This is the master GN build configuration. This file is loaded after the 9 # This is the master GN build configuration. This file is loaded after the
10 # build args (args.gn) for the build directory and after the toplevel ".gn" 10 # build args (args.gn) for the build directory and after the toplevel ".gn"
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 "//build/config/compiler:clang_stackrealign", 512 "//build/config/compiler:clang_stackrealign",
513 "//build/config/compiler:compiler_arm_fpu", 513 "//build/config/compiler:compiler_arm_fpu",
514 "//build/config/compiler:compiler_arm_thumb", 514 "//build/config/compiler:compiler_arm_thumb",
515 "//build/config/compiler:chromium_code", 515 "//build/config/compiler:chromium_code",
516 "//build/config/compiler:default_include_dirs", 516 "//build/config/compiler:default_include_dirs",
517 "//build/config/compiler:default_optimization", 517 "//build/config/compiler:default_optimization",
518 "//build/config/compiler:default_stack_frames", 518 "//build/config/compiler:default_stack_frames",
519 "//build/config/compiler:default_symbols", 519 "//build/config/compiler:default_symbols",
520 "//build/config/compiler:no_rtti", 520 "//build/config/compiler:no_rtti",
521 "//build/config/compiler:runtime_library", 521 "//build/config/compiler:runtime_library",
522 "//build/config/libc++:libc++flags",
brettw 2017/06/12 17:55:18 The reason things need to go here is that targets
Tom Anderson 2017/06/16 20:49:50 I think (maybe) cronet needs to remove it so it ca
brettw 2017/06/19 23:40:26 Your current patch doesn't implement this. Since w
522 "//build/config/sanitizers:default_sanitizer_flags", 523 "//build/config/sanitizers:default_sanitizer_flags",
523 ] 524 ]
524 if (is_win) { 525 if (is_win) {
525 default_compiler_configs += [ 526 default_compiler_configs += [
526 "//build/config/win:default_crt", 527 "//build/config/win:default_crt",
527 "//build/config/win:lean_and_mean", 528 "//build/config/win:lean_and_mean",
528 "//build/config/win:nominmax", 529 "//build/config/win:nominmax",
529 "//build/config/win:unicode", 530 "//build/config/win:unicode",
530 "//build/config/win:winver", 531 "//build/config/win:winver",
531 "//build/config/win:vs_code_analysis", 532 "//build/config/win:vs_code_analysis",
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 set_defaults("component") { 691 set_defaults("component") {
691 if (is_component_build) { 692 if (is_component_build) {
692 configs = default_shared_library_configs 693 configs = default_shared_library_configs
693 if (is_android) { 694 if (is_android) {
694 configs -= [ "//build/config/android:hide_all_but_jni_onload" ] 695 configs -= [ "//build/config/android:hide_all_but_jni_onload" ]
695 } 696 }
696 } else { 697 } else {
697 configs = default_compiler_configs 698 configs = default_compiler_configs
698 } 699 }
699 } 700 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698