Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2931983003: Move libc++ configs and flags out of //build/config/sanitizers (Closed)
Patch Set: Update installer files Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 03890b992cf6b4cc2cb28c2969ee0c47c84a5590..ff0e60b6cb8d7bcc2c15b0b860542b3f6a39b377 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -281,19 +281,6 @@ config("common_sanitizer_flags") {
}
}
-# TODO(thomasanderson): Move this out of build/config/sanitizers.
-config("libcxx_flags") {
- if (use_custom_libcxx) {
- prefix = "//buildtools/third_party"
- include = "trunk/include"
- cflags_cc = [
- "-nostdinc++",
- "-isystem" + rebase_path("$prefix/libc++/$include", root_build_dir),
- "-isystem" + rebase_path("$prefix/libc++abi/$include", root_build_dir),
- ]
- }
-}
-
config("asan_flags") {
cflags = []
if (is_asan) {
@@ -539,7 +526,6 @@ config("fuzzing_build_mode") {
all_sanitizer_configs = [
":common_sanitizer_flags",
- ":libcxx_flags",
":coverage_flags",
":default_sanitizer_ldflags",
":asan_flags",
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/config/sanitizers/sanitizers.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698