Omnibox UI Experiments: Make vertical margin options increments of 2px

Omnibox UI Experiments: Make vertical margin options increments of 2px

Increments of 4px were too much -- and 16px and 20px were comically
large.

BUG=717777
Review-Url: https://codereview.chromium.org/2931653002
Cr-Commit-Position: refs/heads/master@{#478021}
Committed: https://chromium.googlesource.com/chromium/src/+/0705a49d8d56f04b6178d0d8dceed9c83d2105fb

[tommycli, 2017-06-07 18:39:22]

tommycli@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[tommycli, 2017-06-07 18:39:23]

jdonnelly: PTAL

about:flags are just persisted as integers in the profile. Adding more options
or keeping the same number is harmless.

A previous selection of 20px gets mapped to 12px, in this case. A few of us may
need to re-select the margin they desire, but it's harmless.

[Justin Donnelly, 2017-06-07 19:47:12]

lgtm

On 2017/06/07 18:39:23, tommycli wrote:
> about:flags are just persisted as integers in the profile. Adding more options
> or keeping the same number is harmless.
> 
> A previous selection of 20px gets mapped to 12px, in this case. A few of us
may
> need to re-select the margin they desire, but it's harmless.

Thanks for investigating and clarifying this point.

[tommycli, 2017-06-07 20:02:48]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-06-07 20:02:59]

On 2017/06/07 19:47:12, Justin Donnelly wrote:
> lgtm
> 
> On 2017/06/07 18:39:23, tommycli wrote:
> > about:flags are just persisted as integers in the profile. Adding more
options
> > or keeping the same number is harmless.
> > 
> > A previous selection of 20px gets mapped to 12px, in this case. A few of us
> may
> > need to re-select the margin they desire, but it's harmless.
> 
> Thanks for investigating and clarifying this point.

No problem. Sending it in!

[commit-bot: I haz the power, 2017-06-07 20:03:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:14:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:14:51]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tommycli, 2017-06-08 17:13:06]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-06-08 17:13:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 18:00:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496941986210600, "parent_rev":
"1c096e2ce9376983de84794d675ca74e93c6f579", "commit_rev":
"0705a49d8d56f04b6178d0d8dceed9c83d2105fb"}

[commit-bot: I haz the power, 2017-06-08 18:00:57]

Description was changed from

==========
Omnibox UI Experiments: Make vertical margin options increments of 2px

Increments of 4px were too much -- and 16px and 20px were comically
large.

BUG=717777
==========

to

==========
Omnibox UI Experiments: Make vertical margin options increments of 2px

Increments of 4px were too much -- and 16px and 20px were comically
large.

BUG=717777

Review-Url: https://codereview.chromium.org/2931653002
Cr-Commit-Position: refs/heads/master@{#478021}
Committed:
https://chromium.googlesource.com/chromium/src/+/0705a49d8d56f04b6178d0d8dcee...
==========

[commit-bot: I haz the power, 2017-06-08 18:00:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0705a49d8d56f04b6178d0d8dcee...