Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2931653002: Omnibox UI Experiments: Make vertical margin options increments of 2px (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1050 matching lines...) Expand 10 before | Expand all | Expand 10 after
1061 arraysize(kOmniboxUIMaxAutocompleteMatches6), nullptr}, 1061 arraysize(kOmniboxUIMaxAutocompleteMatches6), nullptr},
1062 {"8 matches", kOmniboxUIMaxAutocompleteMatches8, 1062 {"8 matches", kOmniboxUIMaxAutocompleteMatches8,
1063 arraysize(kOmniboxUIMaxAutocompleteMatches8), nullptr}, 1063 arraysize(kOmniboxUIMaxAutocompleteMatches8), nullptr},
1064 {"10 matches", kOmniboxUIMaxAutocompleteMatches10, 1064 {"10 matches", kOmniboxUIMaxAutocompleteMatches10,
1065 arraysize(kOmniboxUIMaxAutocompleteMatches10), nullptr}, 1065 arraysize(kOmniboxUIMaxAutocompleteMatches10), nullptr},
1066 {"12 matches", kOmniboxUIMaxAutocompleteMatches12, 1066 {"12 matches", kOmniboxUIMaxAutocompleteMatches12,
1067 arraysize(kOmniboxUIMaxAutocompleteMatches12), nullptr}}; 1067 arraysize(kOmniboxUIMaxAutocompleteMatches12), nullptr}};
1068 1068
1069 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = { 1069 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = {
1070 {OmniboxFieldTrial::kUIVerticalMarginParam, "4"}}; 1070 {OmniboxFieldTrial::kUIVerticalMarginParam, "4"}};
1071 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin6px[] = {
1072 {OmniboxFieldTrial::kUIVerticalMarginParam, "6"}};
1071 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = { 1073 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = {
1072 {OmniboxFieldTrial::kUIVerticalMarginParam, "8"}}; 1074 {OmniboxFieldTrial::kUIVerticalMarginParam, "8"}};
1075 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin10px[] = {
1076 {OmniboxFieldTrial::kUIVerticalMarginParam, "10"}};
1073 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = { 1077 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = {
1074 {OmniboxFieldTrial::kUIVerticalMarginParam, "12"}}; 1078 {OmniboxFieldTrial::kUIVerticalMarginParam, "12"}};
1075 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = { 1079 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin14px[] = {
1076 {OmniboxFieldTrial::kUIVerticalMarginParam, "16"}}; 1080 {OmniboxFieldTrial::kUIVerticalMarginParam, "14"}};
1077 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = {
1078 {OmniboxFieldTrial::kUIVerticalMarginParam, "20"}};
1079 1081
1080 const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = { 1082 const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = {
1081 {"4px vertical margin", kOmniboxUIVerticalMargin4px, 1083 {"4px vertical margin", kOmniboxUIVerticalMargin4px,
1082 arraysize(kOmniboxUIVerticalMargin4px), nullptr}, 1084 arraysize(kOmniboxUIVerticalMargin4px), nullptr},
1085 {"6px vertical margin", kOmniboxUIVerticalMargin6px,
1086 arraysize(kOmniboxUIVerticalMargin6px), nullptr},
1083 {"8px vertical margin", kOmniboxUIVerticalMargin8px, 1087 {"8px vertical margin", kOmniboxUIVerticalMargin8px,
1084 arraysize(kOmniboxUIVerticalMargin8px), nullptr}, 1088 arraysize(kOmniboxUIVerticalMargin8px), nullptr},
1089 {"10px vertical margin", kOmniboxUIVerticalMargin10px,
1090 arraysize(kOmniboxUIVerticalMargin10px), nullptr},
1085 {"12px vertical margin", kOmniboxUIVerticalMargin12px, 1091 {"12px vertical margin", kOmniboxUIVerticalMargin12px,
1086 arraysize(kOmniboxUIVerticalMargin12px), nullptr}, 1092 arraysize(kOmniboxUIVerticalMargin12px), nullptr},
1087 {"16px vertical margin", kOmniboxUIVerticalMargin16px, 1093 {"14px vertical margin", kOmniboxUIVerticalMargin14px,
1088 arraysize(kOmniboxUIVerticalMargin16px), nullptr}, 1094 arraysize(kOmniboxUIVerticalMargin14px), nullptr}};
1089 {"20px vertical margin", kOmniboxUIVerticalMargin20px,
1090 arraysize(kOmniboxUIVerticalMargin20px), nullptr}};
1091 1095
1092 // RECORDING USER METRICS FOR FLAGS: 1096 // RECORDING USER METRICS FOR FLAGS:
1093 // ----------------------------------------------------------------------------- 1097 // -----------------------------------------------------------------------------
1094 // The first line of the entry is the internal name. 1098 // The first line of the entry is the internal name.
1095 // 1099 //
1096 // To add a new entry, add to the end of kFeatureEntries. There are two 1100 // To add a new entry, add to the end of kFeatureEntries. There are two
1097 // distinct types of entries: 1101 // distinct types of entries:
1098 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE 1102 // . SINGLE_VALUE: entry is either on or off. Use the SINGLE_VALUE_TYPE
1099 // macro for this type supplying the command line to the macro. 1103 // macro for this type supplying the command line to the macro.
1100 // . MULTI_VALUE: a list of choices, the first of which should correspond to a 1104 // . MULTI_VALUE: a list of choices, the first of which should correspond to a
(...skipping 2182 matching lines...) Expand 10 before | Expand all | Expand 10 after
3283 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3287 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3284 3288
3285 const FeatureEntry* GetFeatureEntries(size_t* count) { 3289 const FeatureEntry* GetFeatureEntries(size_t* count) {
3286 *count = arraysize(kFeatureEntries); 3290 *count = arraysize(kFeatureEntries);
3287 return kFeatureEntries; 3291 return kFeatureEntries;
3288 } 3292 }
3289 3293
3290 } // namespace testing 3294 } // namespace testing
3291 3295
3292 } // namespace about_flags 3296 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698