Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/about_flags.cc

Issue 2931653002: Omnibox UI Experiments: Make vertical margin options increments of 2px (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 1e035698c7c4dc4dcc5e10ed92ab0e02a6638bbf..fb2318e3bdb6601169fd249eaff9db0e50595b45 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1068,26 +1068,30 @@ const FeatureEntry::FeatureVariation
const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = {
{OmniboxFieldTrial::kUIVerticalMarginParam, "4"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin6px[] = {
+ {OmniboxFieldTrial::kUIVerticalMarginParam, "6"}};
const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = {
{OmniboxFieldTrial::kUIVerticalMarginParam, "8"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin10px[] = {
+ {OmniboxFieldTrial::kUIVerticalMarginParam, "10"}};
const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = {
{OmniboxFieldTrial::kUIVerticalMarginParam, "12"}};
-const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = {
- {OmniboxFieldTrial::kUIVerticalMarginParam, "16"}};
-const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = {
- {OmniboxFieldTrial::kUIVerticalMarginParam, "20"}};
+const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin14px[] = {
+ {OmniboxFieldTrial::kUIVerticalMarginParam, "14"}};
const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = {
{"4px vertical margin", kOmniboxUIVerticalMargin4px,
arraysize(kOmniboxUIVerticalMargin4px), nullptr},
+ {"6px vertical margin", kOmniboxUIVerticalMargin6px,
+ arraysize(kOmniboxUIVerticalMargin6px), nullptr},
{"8px vertical margin", kOmniboxUIVerticalMargin8px,
arraysize(kOmniboxUIVerticalMargin8px), nullptr},
+ {"10px vertical margin", kOmniboxUIVerticalMargin10px,
+ arraysize(kOmniboxUIVerticalMargin10px), nullptr},
{"12px vertical margin", kOmniboxUIVerticalMargin12px,
arraysize(kOmniboxUIVerticalMargin12px), nullptr},
- {"16px vertical margin", kOmniboxUIVerticalMargin16px,
- arraysize(kOmniboxUIVerticalMargin16px), nullptr},
- {"20px vertical margin", kOmniboxUIVerticalMargin20px,
- arraysize(kOmniboxUIVerticalMargin20px), nullptr}};
+ {"14px vertical margin", kOmniboxUIVerticalMargin14px,
+ arraysize(kOmniboxUIVerticalMargin14px), nullptr}};
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698