Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2931333002: [ia32] Add pextrb/pextrw, pinsrb, pshufb/pshuflw and AVX version (Closed)

Created:
3 years, 6 months ago by Jing
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer, bbudge
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Add pextrb/pextrw, pinsrb, pshufb/pshuflw and AVX version Also add vpinsrw BUG= Review-Url: https://codereview.chromium.org/2931333002 Cr-Commit-Position: refs/heads/master@{#45883} Committed: https://chromium.googlesource.com/v8/v8/+/f8df405cf38484f19c7c6c7ca6951b3bab651420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -8 lines) Patch
M src/ia32/assembler-ia32.h View 2 chunks +54 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 6 chunks +86 lines, -7 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 9 chunks +77 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 4 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Jing
3 years, 6 months ago (2017-06-12 07:03:48 UTC) #2
bbudge
lgtm
3 years, 6 months ago (2017-06-12 18:35:20 UTC) #3
Benedikt Meurer
LGTM (rubber-stamped)
3 years, 6 months ago (2017-06-12 18:42:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2931333002/1
3 years, 6 months ago (2017-06-13 01:41:18 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 02:06:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f8df405cf38484f19c7c6c7ca6951b3bab6...

Powered by Google App Engine
This is Rietveld 408576698