Unframe chrome://extensions as it's the last (and only) uber item

Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having a frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2931243002
Cr-Commit-Position: refs/heads/master@{#479167}
Committed: https://chromium.googlesource.com/chromium/src/+/89a0f29866b240fb8e058c00af8bc09c4927639e

[Dan Beam, 2017-06-10 02:44:18]

Description was changed from

==========
Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
==========

to

==========
Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-06-10 02:47:50]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2017-06-10 02:47:56]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2017-06-10 02:48:55]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-10 02:49:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-06-10 02:49:34]

Description was changed from

==========
Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having a frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-06-10 03:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 03:34:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-12 14:17:18]

Nice cleanup!  Looks like we need a bit more, though - in particular, I think
the testing code in extension_webui_apitest (and maybe other places) still
expects there to be an extensions subframe (e.g.,
https://chromium.googlesource.com/chromium/src/+/51e98fac1dfdffcd0c04639bc60a...).
 This looks to be one of the causes of the failing tests.

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_list.js:987:
window.history.replaceState({}, '', '/?options=' + extensionId);
why window.history instead of history?  (I can't find any style rules here, but
it seems odd)

[Dan Beam, 2017-06-12 23:13:13]

On 2017/06/12 14:17:18, Devlin (sheriff Jun 9 - 12) wrote:
> Nice cleanup!  Looks like we need a bit more, though - in particular, I think
> the testing code in extension_webui_apitest (and maybe other places) still
> expects there to be an extensions subframe (e.g.,
>
https://chromium.googlesource.com/chromium/src/+/51e98fac1dfdffcd0c04639bc60a...).
>  This looks to be one of the causes of the failing tests.

It's very hard to reliably run (or even ascertain) the tests affected by this CL
other than via try jobs, so expect to see me keep using the try bots to develop
;)

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_list.js:987:
window.history.replaceState({}, '', '/?options=' + extensionId);
On 2017/06/12 14:17:18, Devlin (sheriff Jun 9 - 12) wrote:
> why window.history instead of history?  (I can't find any style rules here,
but
> it seems odd)

it's because of the way it's externed:
https://github.com/google/closure-compiler/blob/41263520e01176aa03258b3868a23...

[Dan Beam, 2017-06-12 23:14:00]

Patchset #2 (id:60001) has been deleted

[Dan Beam, 2017-06-12 23:14:06]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 23:14:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 00:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 00:23:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-06-13 00:31:29]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:31:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 02:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 02:16:33]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-13 18:04:21]

lgtm

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_list.js:987:
window.history.replaceState({}, '', '/?options=' + extensionId);
On 2017/06/12 23:13:12, Dan Beam wrote:
> On 2017/06/12 14:17:18, Devlin (sheriff Jun 9 - 12) wrote:
> > why window.history instead of history?  (I can't find any style rules here,
> but
> > it seems odd)
> 
> it's because of the way it's externed:
>
https://github.com/google/closure-compiler/blob/41263520e01176aa03258b3868a23...

Ah, interesting...

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/extension_webui_apitest.cc (right):

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/extension_webui_apitest.cc:67:
testing::AssertionResult RunTestOnExtensions(const char* name) {
nit: maybe OnExtensionsPage?  OnExtensions sounds like it's running on a set of
extensions.

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/lazy_background_page_apitest.cc (right):

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/lazy_background_page_apitest.cc:574: auto*
extensions_frame = browser()->tab_strip_model()->GetActiveWebContents();
this is a bit awkward - it's not a frame any more.  Maybe extensions_page,
extensions_contents, etc?

[Dan Beam, 2017-06-13 18:15:15]

dbeam@chromium.org changed reviewers:
+ thestig@chromium.org

[Dan Beam, 2017-06-13 18:15:16]

+thestig@ for browser_about_handler.cc

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/2931243002/diff/40001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_list.js:987:
window.history.replaceState({}, '', '/?options=' + extensionId);
On 2017/06/13 18:04:21, Devlin wrote:
> On 2017/06/12 23:13:12, Dan Beam wrote:
> > On 2017/06/12 14:17:18, Devlin (sheriff Jun 9 - 12) wrote:
> > > why window.history instead of history?  (I can't find any style rules
here,
> > but
> > > it seems odd)
> > 
> > it's because of the way it's externed:
> >
>
https://github.com/google/closure-compiler/blob/41263520e01176aa03258b3868a23...
> 
> Ah, interesting...

Acknowledged.

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/extension_webui_apitest.cc (right):

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/extension_webui_apitest.cc:67:
testing::AssertionResult RunTestOnExtensions(const char* name) {
On 2017/06/13 18:04:21, Devlin wrote:
> nit: maybe OnExtensionsPage?  OnExtensions sounds like it's running on a set
of
> extensions.

Done.

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/lazy_background_page_apitest.cc (right):

https://codereview.chromium.org/2931243002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/lazy_background_page_apitest.cc:574: auto*
extensions_frame = browser()->tab_strip_model()->GetActiveWebContents();
On 2017/06/13 18:04:21, Devlin wrote:
> this is a bit awkward - it's not a frame any more.  Maybe extensions_page,
> extensions_contents, etc?

Done.

[Dan Beam, 2017-06-13 18:15:21]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 18:15:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-06-13 19:04:12]

lgtm

Just checking:

https://codereview.chromium.org/2931243002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/local_discovery/local_discovery.html (left):

https://codereview.chromium.org/2931243002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/local_discovery/local_discovery.html:20: <body
class="uber-frame">
What effect does this have? FWIW, this is x-platform.

[Dan Beam, 2017-06-13 19:20:39]

https://codereview.chromium.org/2931243002/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/local_discovery/local_discovery.html (left):

https://codereview.chromium.org/2931243002/diff/120001/chrome/browser/resourc...
chrome/browser/resources/local_discovery/local_discovery.html:20: <body
class="uber-frame">
On 2017/06/13 19:04:12, Lei Zhang wrote:
> What effect does this have? FWIW, this is x-platform.

none (afaict); it was just copy-pasta.

[Dan Beam, 2017-06-13 19:21:27]

Patchset #5 (id:140001) has been deleted

[Dan Beam, 2017-06-13 19:21:33]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 19:22:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:07:11]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-06-13 21:47:25]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2017-06-13 21:47:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2931243002/#ps160001
(title: "policy_android.css")

[commit-bot: I haz the power, 2017-06-13 21:48:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 21:56:56]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1497390445840400,
"parent_rev": "17264e4231438095a0d19cbe54b89783b9f6d5ca", "commit_rev":
"89a0f29866b240fb8e058c00af8bc09c4927639e"}

[commit-bot: I haz the power, 2017-06-13 21:57:07]

Description was changed from

==========
Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having a frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Unframe chrome://extensions as it's the last (and only) uber item

This means that rather than having a frame structure like this:

  chrome://chrome (window)
    <iframe src="chrome://uber-frame">
    <iframe src="chrome://extensions-frame">

We can just have:

  chrome://extensions (window)

This allows us to remove a bunch of code dealing with this complexity.
Specifically, the C++ guts that does internal routing of messages.
Additionally, some of the chrome://help code is no longer used (that
page now permanently redirects to chrome://settings/help), so I was able
to remove that as well.

However, ChromeOS still uses /options/, and that code pulls in various
resources from help/ and uber/.  I've simplified the most I could as of
the current dependency situation.  The things that were still used by
ChromeOS I simply limited to that platform (most of the resources).

It's possible it may make sense to keep things like uber_shared.css as
it's also used by chrome://policy, but I'm not optimistic until new
designs of many things launch (I haven't heard updates on the Material
Design version of the policy page for a while now).

R=rdevlin.cronin@chromium.org
BUG=728353
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2931243002
Cr-Commit-Position: refs/heads/master@{#479167}
Committed:
https://chromium.googlesource.com/chromium/src/+/89a0f29866b240fb8e058c00af8b...
==========

[commit-bot: I haz the power, 2017-06-13 21:57:09]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/89a0f29866b240fb8e058c00af8b...