Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item (Closed)
Patch Set: policy_android.css Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extensions.js
diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js
index d0dfdd493d00da806a2ae747bcef2f190ddffe0a..e6b511b28f1056d5ce70eaa94eac23d05988f93e 100644
--- a/chrome/browser/resources/extensions/extensions.js
+++ b/chrome/browser/resources/extensions/extensions.js
@@ -4,7 +4,6 @@
// <include src="../../../../ui/webui/resources/js/cr/ui/focus_row.js">
// <include src="../../../../ui/webui/resources/js/cr/ui/focus_grid.js">
-// <include src="../uber/uber_utils.js">
// <include src="drag_and_drop_handler.js">
// <include src="extension_code.js">
// <include src="extension_commands_overlay.js">
@@ -65,13 +64,9 @@ cr.define('extensions', function() {
*/
initialize: function() {
this.setLoading_(true);
- uber.onContentFrameLoaded();
cr.ui.FocusOutlineManager.forDocument(document);
measureCheckboxStrings();
- // Set the title.
- uber.setTitle(loadTimeData.getString('extensionSettings'));
-
var extensionList = new ExtensionList(this);
extensionList.id = 'extension-settings-list';
var wrapper = $('extension-list-wrapper');
@@ -385,7 +380,7 @@ cr.define('extensions', function() {
lastFocused.focus();
$('overlay').removeEventListener('cancelOverlay', f);
- uber.replaceState({}, '');
+ window.history.replaceState({}, '', '/');
});
node.classList.add('showing');
}
@@ -409,9 +404,6 @@ cr.define('extensions', function() {
assert(settings.dragWrapperHandler_).dragEnabled =
!node || node == $('drop-target-overlay');
}
-
- uber.invokeMethodOnParent(node ? 'beginInterceptingEvents' :
- 'stopInterceptingEvents');
};
ExtensionSettings.focusOverlay = function() {
« no previous file with comments | « chrome/browser/resources/extensions/extensions.html ('k') | chrome/browser/resources/local_discovery/local_discovery.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698