Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4761)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 2931243002: Unframe chrome://extensions as it's the last (and only) uber item (Closed)
Patch Set: policy_android.css Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
index 3bf00fe3c22928c7a9dd6f2cc17e8a29af5bda0b..be7b75546cb373e87bb0a7e112f88e1fee49a0db 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
@@ -44,7 +44,7 @@ ExtensionSettingsWebUITest.prototype = {
* @type {string}
* @const
*/
- browsePreload: 'chrome://extensions-frame/',
+ browsePreload: 'chrome://extensions/',
/** @override */
typedefCppFixture: 'ExtensionSettingsUIBrowserTest',
@@ -299,7 +299,7 @@ AutoScrollExtensionSettingsWebUITest.prototype = {
__proto__: BasicExtensionSettingsWebUITest.prototype,
/** @override */
- browsePreload: 'chrome://extensions-frame/?id=' + GOOD_EXTENSION_ID,
+ browsePreload: 'chrome://extensions/?id=' + GOOD_EXTENSION_ID,
/** @override */
testGenPreamble: function() {
@@ -398,7 +398,7 @@ SettingsCommandsExtensionSettingsWebUITest.prototype = {
* @type {string}
* @const
*/
- browsePreload: 'chrome://extensions-frame/configureCommands',
+ browsePreload: 'chrome://extensions/configureCommands',
};
TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'testChromeSendHandler',
@@ -421,8 +421,7 @@ TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'extensionSettingsUri',
assertTrue($('extension-commands-overlay').classList.contains('showing'));
assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
'false');
- assertEquals(window.location.href,
- 'chrome://extensions-frame/configureCommands');
+ assertEquals(window.location.href, 'chrome://extensions/configureCommands');
// Close command overlay.
$('extension-commands-dismiss').click();
@@ -436,7 +435,7 @@ TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'extensionSettingsUri',
var checkExtensionsUrl = function() {
// After closing the overlay, the URL shouldn't include commands overlay
// reference.
- assertEquals(window.location.href, 'chrome://extensions-frame/');
+ assertEquals(window.location.href, 'chrome://extensions/');
this.nextStep();
};

Powered by Google App Engine
This is Rietveld 408576698