DevTools: make debugger's rawLocationToUILocation return nullable type

DevTools: make debugger's rawLocationToUILocation return nullable type

This patch makes DebuggerWorkspaceBinding.rawLocationToUILocation
return nullable UILocation.

This happens if the rawLocation is "outdated". One example of such situation
is using raw location which does not have script (because script has being
collected due to navigation).

BUG=724328
R=dgozman

Review-Url: https://codereview.chromium.org/2931143003
Cr-Commit-Position: refs/heads/master@{#478559}
Committed: https://chromium.googlesource.com/chromium/src/+/c3065567be38abfc0c0354a04e4c48e85f44f49c

[lushnikov, 2017-06-09 19:33:05]

please, take a look

[lushnikov, 2017-06-09 20:20:20]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-09 20:20:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-06-09 20:53:35]

lgtm

[dgozman, 2017-06-09 20:53:44]

A test?

[commit-bot: I haz the power, 2017-06-09 22:34:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 22:34:14]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-06-09 23:12:11]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-06-09 23:12:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2931143003/#ps20001
(title: "add test")

[commit-bot: I haz the power, 2017-06-09 23:12:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 01:02:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 01:02:05]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-06-10 01:18:21]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-06-10 01:18:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 03:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 03:01:16]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2017-06-12 05:21:42]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-06-12 05:21:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 06:54:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497244902985410,
"parent_rev": "e43c9f5c05c4d6a929907441388882a8f1795b46", "commit_rev":
"c3065567be38abfc0c0354a04e4c48e85f44f49c"}

[commit-bot: I haz the power, 2017-06-12 06:55:05]

Description was changed from

==========
DevTools: make debugger's rawLocationToUILocation return nullable type

This patch makes DebuggerWorkspaceBinding.rawLocationToUILocation
return nullable UILocation.

This happens if the rawLocation is "outdated". One example of such situation
is using raw location which does not have script (because script has being
collected due to navigation).

BUG=724328
R=dgozman
==========

to

==========
DevTools: make debugger's rawLocationToUILocation return nullable type

This patch makes DebuggerWorkspaceBinding.rawLocationToUILocation
return nullable UILocation.

This happens if the rawLocation is "outdated". One example of such situation
is using raw location which does not have script (because script has being
collected due to navigation).

BUG=724328
R=dgozman

Review-Url: https://codereview.chromium.org/2931143003
Cr-Commit-Position: refs/heads/master@{#478559}
Committed:
https://chromium.googlesource.com/chromium/src/+/c3065567be38abfc0c0354a04e4c...
==========

[commit-bot: I haz the power, 2017-06-12 06:55:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c3065567be38abfc0c0354a04e4c...

[qyearsley, 2017-06-23 18:15:29]

qyearsley@chromium.org changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2017-06-23 18:15:30]

https://codereview.chromium.org/2931143003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt
(right):

https://codereview.chromium.org/2931143003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt:12:
[ UPDATE ]  LiveLocation-js: debugger:///VM37 sourcemap-script.js:0:0
Just noticed a potential source of flakiness here: the string "VM37" appears to
be host-specific, so this test will have different results when run on different
hosts.

Might this be related to the dumpLocation function?

[dgozman, 2017-06-23 21:25:00]

https://codereview.chromium.org/2931143003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt
(right):

https://codereview.chromium.org/2931143003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt:12:
[ UPDATE ]  LiveLocation-js: debugger:///VM37 sourcemap-script.js:0:0
On 2017/06/23 18:15:30, qyearsley wrote:
> Just noticed a potential source of flakiness here: the string "VM37" appears
to
> be host-specific, so this test will have different results when run on
different
> hosts.
> 
> Might this be related to the dumpLocation function?

Yep. We usually strip these numbers down, but not this time.
Andrey, mind fixing this?