third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js - Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type (Closed)

Patch Set: add test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt ('K') | « third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

index a6ed70a0d709bbafcffdda0cb5bec6aedb04f498..bcfb8663e98e0eed4b9853826c9859e782059955 100644

--- a/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js

@@ -479,9 +479,9 @@ Snippets.SnippetScriptMapping = class {

return;

var rawLocation =

/** @type {!SDK.DebuggerModel.Location} */ (this._debuggerModel.createRawLocation(script, 0, 0));

- var scriptUISourceCode = Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(rawLocation).uiSourceCode;

- if (scriptUISourceCode)

- this._scriptSnippetModel._restoreBreakpoints(scriptUISourceCode, breakpointLocations);

+ var uiLocation = Bindings.debuggerWorkspaceBinding.rawLocationToUILocation(rawLocation);

+ if (uiLocation)

+ this._scriptSnippetModel._restoreBreakpoints(uiLocation.uiSourceCode, breakpointLocations);

}

};