third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js - Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2931143003: DevTools: make debugger's rawLocationToUILocation return nullable type (Closed)

Patch Set: add test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector/bindings/livelocation-main-frame-navigated-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

index 977685711778379b32d1a804f7e2d3a00cb5fc43..0a917c26e724ce9dee5b0292be15b44bfd07888c 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

@@ -923,6 +923,8 @@ Bindings.BreakpointManager.ModelBreakpoint = class {

_addResolvedLocation(location) {

var uiLocation = this._debuggerWorkspaceBinding.rawLocationToUILocation(location);

+ if (!uiLocation)

+ return false;

var breakpoint = this._breakpoint._breakpointManager.findBreakpoint(

uiLocation.uiSourceCode, uiLocation.lineNumber, uiLocation.columnNumber);

if (breakpoint && breakpoint !== this._breakpoint) {