Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp

Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp

This patch moves |LeftPositionOf()| and |RightPositionOf()| with related
functions with tests to "SelectionModifierCharacter.cpp" and
"SelectionModifierTest.cpp" since these functions are used only in
|SelectionModifier| class for improving code health.

This patch also makes moved code C++11'ish, |0| to |nullptr|.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2930863002
Cr-Commit-Position: refs/heads/master@{#478192}
Committed: https://chromium.googlesource.com/chromium/src/+/93057ddbe435d42cbd1c3b39b63276f29076acdc

[yosin_UTC9, 2017-06-08 09:46:25]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 09:46:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-08 09:54:26]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-06-08 09:55:26]

Description was changed from

==========
2017-06-08T18:43:23

BUG=707656

2017-06-08T18:36:15
==========

to

==========
Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp

This patch moves |LeftPositionOf()| and |RightPositionOf()| with related
functions with tests to "SelectionModifierCharacter.cpp" and
"SelectionModifierTest.cpp" since these functions are used only in
|SelectionModifier| class for improving code health.

This patch also makes moved code C++11'ish, |0| to |nullptr|.

BUG=707656
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-08 09:55:31]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 09:55:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 14:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 14:27:47]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-09 03:29:22]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-09 03:29:23]

PTAL

[Xiaocheng, 2017-06-09 03:39:42]

lgtm

[yosin_UTC9, 2017-06-09 03:47:34]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-09 03:47:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 03:51:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496980054721500,
"parent_rev": "74a7fb2fa4307c69812945586b39018ae4f231b2", "commit_rev":
"93057ddbe435d42cbd1c3b39b63276f29076acdc"}

[commit-bot: I haz the power, 2017-06-09 03:52:10]

Description was changed from

==========
Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp

This patch moves |LeftPositionOf()| and |RightPositionOf()| with related
functions with tests to "SelectionModifierCharacter.cpp" and
"SelectionModifierTest.cpp" since these functions are used only in
|SelectionModifier| class for improving code health.

This patch also makes moved code C++11'ish, |0| to |nullptr|.

BUG=707656
TEST=n/a; no behavior changes
==========

to

==========
Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp

This patch moves |LeftPositionOf()| and |RightPositionOf()| with related
functions with tests to "SelectionModifierCharacter.cpp" and
"SelectionModifierTest.cpp" since these functions are used only in
|SelectionModifier| class for improving code health.

This patch also makes moved code C++11'ish, |0| to |nullptr|.

BUG=707656
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2930863002
Cr-Commit-Position: refs/heads/master@{#478192}
Committed:
https://chromium.googlesource.com/chromium/src/+/93057ddbe435d42cbd1c3b39b632...
==========

[commit-bot: I haz the power, 2017-06-09 03:52:12]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/93057ddbe435d42cbd1c3b39b632...