Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Issue 2930863002: Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp (Closed)
Patch Set: 2017-06-08T18:53:47 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
index 8795eb6b3f8b2a76961c3df53c7a35e9cb522301..357b7875f150e862e5e2e99bfd152e6085365fc6 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
@@ -1040,44 +1040,6 @@ TEST_F(VisibleUnitsTest, isVisuallyEquivalentCandidateWithDocument) {
EXPECT_FALSE(IsVisuallyEquivalentCandidate(Position(&GetDocument(), 0)));
}
-TEST_F(VisibleUnitsTest, leftPositionOf) {
- const char* body_content =
- "<b id=zero>0</b><p id=host><b id=one>1</b><b id=two>22</b></p><b "
- "id=three>333</b>";
- const char* shadow_content =
- "<b id=four>4444</b><content select=#two></content><content "
- "select=#one></content><b id=five>55555</b>";
- SetBodyContent(body_content);
- ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
-
- Element* one = GetDocument().getElementById("one");
- Element* two = GetDocument().getElementById("two");
- Element* three = GetDocument().getElementById("three");
- Element* four = shadow_root->getElementById("four");
- Element* five = shadow_root->getElementById("five");
-
- EXPECT_EQ(
- Position(two->firstChild(), 1),
- LeftPositionOf(CreateVisiblePosition(Position(one, 0))).DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(two->firstChild(), 1),
- LeftPositionOf(CreateVisiblePosition(PositionInFlatTree(one, 0)))
- .DeepEquivalent());
-
- EXPECT_EQ(
- Position(one->firstChild(), 0),
- LeftPositionOf(CreateVisiblePosition(Position(two, 0))).DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(four->firstChild(), 3),
- LeftPositionOf(CreateVisiblePosition(PositionInFlatTree(two, 0)))
- .DeepEquivalent());
-
- EXPECT_EQ(Position(two->firstChild(), 2),
- LeftPositionOf(CreateVisiblePosition(Position(three, 0)))
- .DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(five->firstChild(), 5),
- LeftPositionOf(CreateVisiblePosition(PositionInFlatTree(three, 0)))
- .DeepEquivalent());
-}
-
TEST_F(VisibleUnitsTest, localCaretRectOfPosition) {
const char* body_content =
"<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
@@ -1615,50 +1577,6 @@ TEST_F(VisibleUnitsTest, renderedOffset) {
Position(sample2->firstChild(), 0)));
}
-TEST_F(VisibleUnitsTest, rightPositionOf) {
- const char* body_content =
- "<b id=zero>0</b><p id=host><b id=one>1</b><b id=two>22</b></p><b "
- "id=three>333</b>";
- const char* shadow_content =
- "<p id=four>4444</p><content select=#two></content><content "
- "select=#one></content><p id=five>55555</p>";
- SetBodyContent(body_content);
- ShadowRoot* shadow_root = SetShadowContent(shadow_content, "host");
-
- Node* one = GetDocument().getElementById("one")->firstChild();
- Node* two = GetDocument().getElementById("two")->firstChild();
- Node* three = GetDocument().getElementById("three")->firstChild();
- Node* four = shadow_root->getElementById("four")->firstChild();
- Node* five = shadow_root->getElementById("five")->firstChild();
-
- EXPECT_EQ(Position(), RightPositionOf(CreateVisiblePosition(Position(one, 1)))
- .DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(five, 0),
- RightPositionOf(CreateVisiblePosition(PositionInFlatTree(one, 1)))
- .DeepEquivalent());
-
- EXPECT_EQ(Position(one, 1),
- RightPositionOf(CreateVisiblePosition(Position(two, 2)))
- .DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(one, 1),
- RightPositionOf(CreateVisiblePosition(PositionInFlatTree(two, 2)))
- .DeepEquivalent());
-
- EXPECT_EQ(Position(five, 0),
- RightPositionOf(CreateVisiblePosition(Position(four, 4)))
- .DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(two, 0),
- RightPositionOf(CreateVisiblePosition(PositionInFlatTree(four, 4)))
- .DeepEquivalent());
-
- EXPECT_EQ(Position(),
- RightPositionOf(CreateVisiblePosition(Position(five, 5)))
- .DeepEquivalent());
- EXPECT_EQ(PositionInFlatTree(three, 0),
- RightPositionOf(CreateVisiblePosition(PositionInFlatTree(five, 5)))
- .DeepEquivalent());
-}
-
TEST_F(VisibleUnitsTest, startOfDocument) {
const char* body_content = "<a id=host><b id=one>1</b><b id=two>22</b></a>";
const char* shadow_content =
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698