Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.h

Issue 2930863002: Move LeftPositionOf() and RightPositionOf() to SelectionModifierCharacter.cpp (Closed)
Patch Set: 2017-06-08T18:53:47 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.h b/third_party/WebKit/Source/core/editing/VisibleUnits.h
index e56dcb764702d0f454347162909dfb62a26a93c3..532ff463e39fb55232bb62d8d03a4ed2b25c7ce2 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.h
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.h
@@ -130,19 +130,6 @@ CORE_EXPORT UChar32 CharacterAfter(const VisiblePositionInFlatTree&);
CORE_EXPORT UChar32 CharacterBefore(const VisiblePosition&);
CORE_EXPORT UChar32 CharacterBefore(const VisiblePositionInFlatTree&);
-// TODO(yosin) Since return value of |leftPositionOf()| with |VisiblePosition|
-// isn't defined well on flat tree, we should not use it for a position in
-// flat tree.
-CORE_EXPORT VisiblePosition LeftPositionOf(const VisiblePosition&);
-CORE_EXPORT VisiblePositionInFlatTree
-LeftPositionOf(const VisiblePositionInFlatTree&);
-// TODO(yosin) Since return value of |rightPositionOf()| with |VisiblePosition|
-// isn't defined well on flat tree, we should not use it for a position in
-// flat tree.
-CORE_EXPORT VisiblePosition RightPositionOf(const VisiblePosition&);
-CORE_EXPORT VisiblePositionInFlatTree
-RightPositionOf(const VisiblePositionInFlatTree&);
-
CORE_EXPORT VisiblePosition
NextPositionOf(const VisiblePosition&,
EditingBoundaryCrossingRule = kCanCrossEditingBoundary);
@@ -377,6 +364,10 @@ VisiblePositionInFlatTree HonorEditingBoundaryAtOrAfter(
VisiblePosition HonorEditingBoundaryAtOrBefore(const VisiblePosition&,
const Position&);
+VisiblePositionInFlatTree HonorEditingBoundaryAtOrBefore(
+ const VisiblePositionInFlatTree&,
+ const PositionInFlatTree&);
+
Position NextRootInlineBoxCandidatePosition(Node*,
const VisiblePosition&,
EditableType);

Powered by Google App Engine
This is Rietveld 408576698