Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2930513004: [WIP] Move ImageDecoders to SkCodec

Created:
3 years, 6 months ago by naga
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Move ImageDecoders to SkCodec Use SkCodec for image decoding. BUG=None R=SamsungPeerReview

Patch Set 1 : Initial patch to use skia codec for image decoding #

Patch Set 2 : Adding check for decoder creation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -9923 lines) Patch
M skia/BUILD.gn View 4 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebImageDecoder.cpp View 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 2 chunks +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageSource.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.h View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp View 1 chunk +0 lines, -243 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 16 chunks +33 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 6 chunks +184 lines, -75 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.h View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp View 1 chunk +0 lines, -125 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.h View 1 chunk +0 lines, -370 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp View 1 chunk +0 lines, -856 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp View 1 chunk +0 lines, -282 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 1 chunk +0 lines, -440 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h View 1 chunk +0 lines, -370 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 chunk +0 lines, -899 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h View 1 chunk +0 lines, -186 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp View 1 chunk +0 lines, -340 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 1 chunk +0 lines, -1017 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 1 chunk +0 lines, -315 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.h View 1 chunk +0 lines, -83 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 1 chunk +0 lines, -492 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoderTest.cpp View 1 chunk +0 lines, -1057 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.h View 1 chunk +0 lines, -170 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp View 1 chunk +0 lines, -690 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 chunk +0 lines, -525 lines 0 comments Download
D third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 chunk +0 lines, -554 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
cblume
3 years, 6 months ago (2017-06-07 16:51:53 UTC) #3 
Not all Sk*Codecs are ready, so we can't land them all in one big chunk like
this.

In addition to that, this patch doesn't handle JPEG's YUV, progressive decode,
and first-frame transparency during partial decode to name a few.

As you pointed out, there is already work being done to move over to using
SkCodec here https://codereview.chromium.org/2565323003
Since each Sk*Codec will become ready at different times, the main bug
https://bugs.chromium.org/p/chromium/issues/detail?id=663569 is blocked on
individual bugs for each Sk*Codec.

Powered by Google App Engine
This is Rietveld 408576698