Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp

Issue 2930513004: [WIP] Move ImageDecoders to SkCodec
Patch Set: Adding check for decoder creation Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp
deleted file mode 100644
index 0a0966458226cbe628dfa0e82d55bc3056ef56c0..0000000000000000000000000000000000000000
--- a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp
+++ /dev/null
@@ -1,243 +0,0 @@
-/*
- * Copyright (C) 2015 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "platform/image-decoders/FastSharedBufferReader.h"
-#include "platform/image-decoders/SegmentReader.h"
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace blink {
-
-namespace {
-
-const unsigned kDefaultTestSize = 4 * SharedBuffer::kSegmentSize;
-
-void PrepareReferenceData(char* buffer, size_t size) {
- for (size_t i = 0; i < size; ++i)
- buffer[i] = static_cast<char>(i);
-}
-
-PassRefPtr<SegmentReader> CopyToROBufferSegmentReader(
- PassRefPtr<SegmentReader> input) {
- SkRWBuffer rw_buffer;
- const char* segment = 0;
- size_t position = 0;
- while (size_t length = input->GetSomeData(segment, position)) {
- rw_buffer.append(segment, length);
- position += length;
- }
- return SegmentReader::CreateFromSkROBuffer(
- sk_sp<SkROBuffer>(rw_buffer.newRBufferSnapshot()));
-}
-
-PassRefPtr<SegmentReader> CopyToDataSegmentReader(
- PassRefPtr<SegmentReader> input) {
- return SegmentReader::CreateFromSkData(input->GetAsSkData());
-}
-
-struct SegmentReaders {
- RefPtr<SegmentReader> segment_readers[3];
-
- SegmentReaders(PassRefPtr<SharedBuffer> input) {
- segment_readers[0] =
- SegmentReader::CreateFromSharedBuffer(std::move(input));
- segment_readers[1] = CopyToROBufferSegmentReader(segment_readers[0]);
- segment_readers[2] = CopyToDataSegmentReader(segment_readers[0]);
- }
-};
-
-} // namespace
-
-TEST(FastSharedBufferReaderTest, nonSequentialReads) {
- char reference_data[kDefaultTestSize];
- PrepareReferenceData(reference_data, sizeof(reference_data));
- RefPtr<SharedBuffer> data = SharedBuffer::Create();
- data->Append(reference_data, sizeof(reference_data));
-
- SegmentReaders reader_struct(data);
- for (auto segment_reader : reader_struct.segment_readers) {
- FastSharedBufferReader reader(segment_reader);
- // Read size is prime such there will be a segment-spanning
- // read eventually.
- char temp_buffer[17];
- for (size_t data_position = 0;
- data_position + sizeof(temp_buffer) < sizeof(reference_data);
- data_position += sizeof(temp_buffer)) {
- const char* block = reader.GetConsecutiveData(
- data_position, sizeof(temp_buffer), temp_buffer);
- ASSERT_FALSE(
- memcmp(block, reference_data + data_position, sizeof(temp_buffer)));
- }
- }
-}
-
-TEST(FastSharedBufferReaderTest, readBackwards) {
- char reference_data[kDefaultTestSize];
- PrepareReferenceData(reference_data, sizeof(reference_data));
- RefPtr<SharedBuffer> data = SharedBuffer::Create();
- data->Append(reference_data, sizeof(reference_data));
-
- SegmentReaders reader_struct(data);
- for (auto segment_reader : reader_struct.segment_readers) {
- FastSharedBufferReader reader(segment_reader);
- // Read size is prime such there will be a segment-spanning
- // read eventually.
- char temp_buffer[17];
- for (size_t data_offset = sizeof(temp_buffer);
- data_offset < sizeof(reference_data);
- data_offset += sizeof(temp_buffer)) {
- const char* block =
- reader.GetConsecutiveData(sizeof(reference_data) - data_offset,
- sizeof(temp_buffer), temp_buffer);
- ASSERT_FALSE(memcmp(block,
- reference_data + sizeof(reference_data) - data_offset,
- sizeof(temp_buffer)));
- }
- }
-}
-
-TEST(FastSharedBufferReaderTest, byteByByte) {
- char reference_data[kDefaultTestSize];
- PrepareReferenceData(reference_data, sizeof(reference_data));
- RefPtr<SharedBuffer> data = SharedBuffer::Create();
- data->Append(reference_data, sizeof(reference_data));
-
- SegmentReaders reader_struct(data);
- for (auto segment_reader : reader_struct.segment_readers) {
- FastSharedBufferReader reader(segment_reader);
- for (size_t i = 0; i < sizeof(reference_data); ++i) {
- ASSERT_EQ(reference_data[i], reader.GetOneByte(i));
- }
- }
-}
-
-// Tests that a read from inside the penultimate segment to the very end of the
-// buffer doesn't try to read off the end of the buffer.
-TEST(FastSharedBufferReaderTest, readAllOverlappingLastSegmentBoundary) {
- const unsigned kDataSize = 2 * SharedBuffer::kSegmentSize;
- char reference_data[kDataSize];
- PrepareReferenceData(reference_data, kDataSize);
- RefPtr<SharedBuffer> data = SharedBuffer::Create();
- data->Append(reference_data, kDataSize);
-
- SegmentReaders reader_struct(data);
- for (auto segment_reader : reader_struct.segment_readers) {
- FastSharedBufferReader reader(segment_reader);
- char buffer[kDataSize];
- reader.GetConsecutiveData(0, kDataSize, buffer);
- ASSERT_FALSE(memcmp(buffer, reference_data, kDataSize));
- }
-}
-
-// Verify that reading past the end of the buffer does not break future reads.
-TEST(SegmentReaderTest, readPastEndThenRead) {
- const unsigned kDataSize = 2 * SharedBuffer::kSegmentSize;
- char reference_data[kDataSize];
- PrepareReferenceData(reference_data, kDataSize);
- RefPtr<SharedBuffer> data = SharedBuffer::Create();
- data->Append(reference_data, kDataSize);
-
- SegmentReaders reader_struct(data);
- for (auto segment_reader : reader_struct.segment_readers) {
- const char* contents;
- size_t length = segment_reader->GetSomeData(contents, kDataSize);
- EXPECT_EQ(0u, length);
-
- length = segment_reader->GetSomeData(contents, 0);
- EXPECT_LE(SharedBuffer::kSegmentSize, length);
- }
-}
-
-TEST(SegmentReaderTest, getAsSkData) {
- const unsigned kDataSize = 4 * SharedBuffer::kSegmentSize;
- char reference_data[kDataSize];
- PrepareReferenceData(reference_data, kDataSize);
- RefPtr<SharedBuffer> data = SharedBuffer::Create();
- data->Append(reference_data, kDataSize);
-
- SegmentReaders reader_struct(data);
- for (auto segment_reader : reader_struct.segment_readers) {
- sk_sp<SkData> skdata = segment_reader->GetAsSkData();
- EXPECT_EQ(data->size(), skdata->size());
-
- const char* segment;
- size_t position = 0;
- for (size_t length = segment_reader->GetSomeData(segment, position); length;
- length = segment_reader->GetSomeData(segment, position)) {
- ASSERT_FALSE(memcmp(segment, skdata->bytes() + position, length));
- position += length;
- }
- EXPECT_EQ(position, kDataSize);
- }
-}
-
-TEST(SegmentReaderTest, variableSegments) {
- const size_t kDataSize = 3.5 * SharedBuffer::kSegmentSize;
- char reference_data[kDataSize];
- PrepareReferenceData(reference_data, kDataSize);
-
- RefPtr<SegmentReader> segment_reader;
- {
- // Create a SegmentReader with difference sized segments, to test that
- // the SkROBuffer implementation works when two consecutive segments
- // are not the same size. This test relies on knowledge of the
- // internals of SkRWBuffer: it ensures that each segment is at least
- // 4096 (though the actual data may be smaller, if it has not been
- // written to yet), but when appending a larger amount it may create a
- // larger segment.
- SkRWBuffer rw_buffer;
- rw_buffer.append(reference_data, SharedBuffer::kSegmentSize);
- rw_buffer.append(reference_data + SharedBuffer::kSegmentSize,
- 2 * SharedBuffer::kSegmentSize);
- rw_buffer.append(reference_data + 3 * SharedBuffer::kSegmentSize,
- .5 * SharedBuffer::kSegmentSize);
-
- segment_reader = SegmentReader::CreateFromSkROBuffer(
- sk_sp<SkROBuffer>(rw_buffer.newRBufferSnapshot()));
- }
-
- const char* segment;
- size_t position = 0;
- size_t last_length = 0;
- for (size_t length = segment_reader->GetSomeData(segment, position); length;
- length = segment_reader->GetSomeData(segment, position)) {
- // It is not a bug to have consecutive segments of the same length, but
- // it does mean that the following test does not actually test what it
- // is intended to test.
- ASSERT_NE(length, last_length);
- last_length = length;
-
- ASSERT_FALSE(memcmp(segment, reference_data + position, length));
- position += length;
- }
- EXPECT_EQ(position, kDataSize);
-}
-
-} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698