Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/renderer/media/media_stream_audio_processor_unittest.cc

Issue 293023003: Change kEnableAudioTrackProcessing to a disable flag and remove finch code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits to fix more bots. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_audio_processor_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_processor_unittest.cc b/content/renderer/media/media_stream_audio_processor_unittest.cc
index 233f30d04c7dbc8d936ab6ce8be9ae84fbe6298b..d48f1c56940c964ca42a11e1993e00dadc552f30 100644
--- a/content/renderer/media/media_stream_audio_processor_unittest.cc
+++ b/content/renderer/media/media_stream_audio_processor_unittest.cc
@@ -153,7 +153,9 @@ class MediaStreamAudioProcessorTest : public ::testing::Test {
};
TEST_F(MediaStreamAudioProcessorTest, WithoutAudioProcessing) {
- // Setup the audio processor without enabling the flag.
+ // Setup the audio processor with disabled flag on.
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kDisableAudioTrackProcessing);
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
@@ -174,9 +176,6 @@ TEST_F(MediaStreamAudioProcessorTest, WithoutAudioProcessing) {
}
TEST_F(MediaStreamAudioProcessorTest, WithAudioProcessing) {
- // Setup the audio processor with the flag enabled.
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableAudioTrackProcessing);
MockMediaConstraintFactory constraint_factory;
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
@@ -198,9 +197,6 @@ TEST_F(MediaStreamAudioProcessorTest, WithAudioProcessing) {
}
TEST_F(MediaStreamAudioProcessorTest, VerifyTabCaptureWithoutAudioProcessing) {
- // Setup the audio processor with enabling the flag.
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableAudioTrackProcessing);
scoped_refptr<WebRtcAudioDeviceImpl> webrtc_audio_device(
new WebRtcAudioDeviceImpl());
// Create MediaStreamAudioProcessor instance for kMediaStreamSourceTab source.
@@ -237,10 +233,6 @@ TEST_F(MediaStreamAudioProcessorTest, VerifyTabCaptureWithoutAudioProcessing) {
}
TEST_F(MediaStreamAudioProcessorTest, TurnOffDefaultConstraints) {
- // Setup the audio processor with enabling the flag.
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableAudioTrackProcessing);
-
// Turn off the default constraints and pass it to MediaStreamAudioProcessor.
MockMediaConstraintFactory constraint_factory;
constraint_factory.DisableDefaultAudioConstraints();
@@ -263,10 +255,6 @@ TEST_F(MediaStreamAudioProcessorTest, TurnOffDefaultConstraints) {
}
TEST_F(MediaStreamAudioProcessorTest, VerifyConstraints) {
- // Setup the audio processor with enabling the flag.
- CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableAudioTrackProcessing);
-
static const char* kDefaultAudioConstraints[] = {
MediaAudioConstraints::kEchoCancellation,
MediaAudioConstraints::kGoogAudioMirroring,

Powered by Google App Engine
This is Rietveld 408576698