content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc - Issue 293023003: Change kEnableAudioTrackProcessing to a disable flag and remove finch code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc

Issue 293023003: Change kEnableAudioTrackProcessing to a disable flag and remove finch code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: nits to fix more bots. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/peer_connection_dependency_factory.cc ('k') | content/renderer/media/webrtc_audio_capturer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc

diff --git a/content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc b/content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc

index 7f448291d84f6998eef2bfbbfafd2c8cb167d2ed..693067ac93989316d408517ffd03b759e8697a40 100644

--- a/content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc

+++ b/content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc

@@ -88,12 +88,12 @@ TEST_F(WebRtcLocalAudioTrackAdapterTest, GetSignalLevel) {

webrtc::AudioTrackInterface* webrtc_track =

static_cast<webrtc::AudioTrackInterface*>(adapter_.get());

int signal_level = 0;

- EXPECT_FALSE(webrtc_track->GetSignalLevel(&signal_level));

+ EXPECT_TRUE(webrtc_track->GetSignalLevel(&signal_level));

- // Enable the audio processing in the audio track.

+ // Disable the audio processing in the audio track.

CommandLine::ForCurrentProcess()->AppendSwitch(

- switches::kEnableAudioTrackProcessing);

- EXPECT_TRUE(webrtc_track->GetSignalLevel(&signal_level));

+ switches::kDisableAudioTrackProcessing);

+ EXPECT_FALSE(webrtc_track->GetSignalLevel(&signal_level));

}

} // namespace content