Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Unified Diff: content/renderer/media/webrtc_audio_capturer_unittest.cc

Issue 293023003: Change kEnableAudioTrackProcessing to a disable flag and remove finch code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits to fix more bots. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_audio_capturer_unittest.cc
diff --git a/content/renderer/media/webrtc_audio_capturer_unittest.cc b/content/renderer/media/webrtc_audio_capturer_unittest.cc
index d5f8db44b5478b497f7fc69017d5bf2588651f86..0011f7630597f323e2cb07522df7e4e269c3f1ef 100644
--- a/content/renderer/media/webrtc_audio_capturer_unittest.cc
+++ b/content/renderer/media/webrtc_audio_capturer_unittest.cc
@@ -84,9 +84,9 @@ class WebRtcAudioCapturerTest : public testing::Test {
#endif
}
- void EnableAudioTrackProcessing() {
+ void DisableAudioTrackProcessing() {
CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableAudioTrackProcessing);
+ switches::kDisableAudioTrackProcessing);
}
void VerifyAudioParams(const blink::WebMediaConstraints& constraints,
@@ -156,14 +156,14 @@ class WebRtcAudioCapturerTest : public testing::Test {
// Pass the delay value, volume and key_pressed info via capture callback, and
// those values should be correctly stored and passed to the track.
-TEST_F(WebRtcAudioCapturerTest, VerifyAudioParams) {
+TEST_F(WebRtcAudioCapturerTest, VerifyAudioParamsWithoutAudioProcessing) {
+ DisableAudioTrackProcessing();
// Use constraints with default settings.
MockMediaConstraintFactory constraint_factory;
VerifyAudioParams(constraint_factory.CreateWebMediaConstraints(), true);
}
TEST_F(WebRtcAudioCapturerTest, VerifyAudioParamsWithAudioProcessing) {
- EnableAudioTrackProcessing();
// Turn off the default constraints to verify that the sink will get packets
// with a buffer size smaller than 10ms.
MockMediaConstraintFactory constraint_factory;
@@ -172,7 +172,6 @@ TEST_F(WebRtcAudioCapturerTest, VerifyAudioParamsWithAudioProcessing) {
}
TEST_F(WebRtcAudioCapturerTest, FailToCreateCapturerWithWrongConstraints) {
- EnableAudioTrackProcessing();
MockMediaConstraintFactory constraint_factory;
const std::string dummy_constraint = "dummy";
constraint_factory.AddMandatory(dummy_constraint, true);

Powered by Google App Engine
This is Rietveld 408576698