Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2929903002: aura: Remove NotifyAncestorWindowTransformed in window observer. (Closed)

Created:
3 years, 6 months ago by sammiequon
Modified:
3 years, 6 months ago
Reviewers:
mohsen, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

aura: Remove NotifyAncestorWindowTransformed in window observer. This was only used for hiding touch handles on rotate which was recently removed in https://codereview.chromium.org/2924893002/. This is a revert https://codereview.chromium.org/558203002. TEST=none BUG=476320 Review-Url: https://codereview.chromium.org/2929903002 Cr-Commit-Position: refs/heads/master@{#478136} Committed: https://chromium.googlesource.com/chromium/src/+/6289aad0111c840801e62692e6aa8b98e7e33ec6

Patch Set 1 #

Patch Set 2 : Fix aura_unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M ui/aura/window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/aura/window_observer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 3 chunks +0 lines, -44 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
sammiequon
mohsen@ - Please take a look. Thanks!
3 years, 6 months ago (2017-06-08 18:50:07 UTC) #3
mohsen
lgtm
3 years, 6 months ago (2017-06-08 18:55:57 UTC) #4
sammiequon
On 2017/06/08 18:55:57, mohsen wrote: > lgtm Thanks! sky@ - Please take a look. Thanks!
3 years, 6 months ago (2017-06-08 19:03:55 UTC) #6
sky
LGTM
3 years, 6 months ago (2017-06-08 21:33:16 UTC) #11
sammiequon
On 2017/06/08 21:33:16, sky wrote: > LGTM Thanks!
3 years, 6 months ago (2017-06-08 21:54:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2929903002/20001
3 years, 6 months ago (2017-06-09 00:25:54 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 00:31:50 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6289aad0111c840801e62692e6aa...

Powered by Google App Engine
This is Rietveld 408576698