touch ui: Do not hide text selection handles when screen is rotated.

touch ui: Do not hide text selection handles when screen is rotated.

The text selection handles currently disappear when the device is rotated in tablet mode.

TEST=manual
BUG=476320
Review-Url: https://codereview.chromium.org/2924893002
Cr-Commit-Position: refs/heads/master@{#477716}
Committed: https://chromium.googlesource.com/chromium/src/+/69e032ada751d14f68658812ab90883bd7fabbc4

[sammiequon, 2017-06-06 19:01:09]

Description was changed from

==========
touch ui: Do not hide text selection handles when screen is rotated.

The text selection handles currently disappear when the device is rotated in
tablet mode.

TEST=manual
BUG=476320
==========

to

==========
touch ui: Do not hide text selection handles when screen is rotated.

The text selection handles currently disappear when the device is rotated in
tablet mode.

TEST=manual
BUG=476320
==========

[sammiequon, 2017-06-06 19:01:09]

sammiequon@chromium.org changed reviewers:
+ mohsen@chromium.org

[sammiequon, 2017-06-06 19:01:28]

mohsen@ - Please take a look. Thanks!

https://codereview.chromium.org/2924893002/diff/1/ui/views/touchui/touch_sele...
File ui/views/touchui/touch_selection_controller_impl.cc (left):

https://codereview.chromium.org/2924893002/diff/1/ui/views/touchui/touch_sele...
ui/views/touchui/touch_selection_controller_impl.cc:651: 
Would removing this have other undesired effects?

[sammiequon, 2017-06-06 19:01:32]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 19:02:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 19:14:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 19:14:31]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2017-06-06 19:30:35]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 19:31:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 21:00:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 21:00:21]

Dry run: This issue passed the CQ dry run.

[mohsen, 2017-06-07 18:20:38]

lgtm

https://codereview.chromium.org/2924893002/diff/1/ui/views/touchui/touch_sele...
File ui/views/touchui/touch_selection_controller_impl.cc (left):

https://codereview.chromium.org/2924893002/diff/1/ui/views/touchui/touch_sele...
ui/views/touchui/touch_selection_controller_impl.cc:651: 
On 2017/06/06 19:01:27, sammiequon wrote:
> Would removing this have other undesired effects?

This was added for Project Athena where we had textfields that could move around
(crbug/407659). That project was cancelled and I'm not aware of any existing
code that applies such transforms on a focused textfield.

[sammiequon, 2017-06-07 18:53:50]

Thanks!

https://codereview.chromium.org/2924893002/diff/1/ui/views/touchui/touch_sele...
File ui/views/touchui/touch_selection_controller_impl.cc (left):

https://codereview.chromium.org/2924893002/diff/1/ui/views/touchui/touch_sele...
ui/views/touchui/touch_selection_controller_impl.cc:651: 
On 2017/06/07 18:20:38, mohsen wrote:
> On 2017/06/06 19:01:27, sammiequon wrote:
> > Would removing this have other undesired effects?
> 
> This was added for Project Athena where we had textfields that could move
around
> (crbug/407659). That project was cancelled and I'm not aware of any existing
> code that applies such transforms on a focused textfield.

Acknowledged. Do you think we should revert
https://codereview.chromium.org/558203002 as well, since this is the only
instance of OnAncestorWindowTransformed?

[sammiequon, 2017-06-07 18:54:02]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2017-06-07 18:54:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 19:00:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496861642475240,
"parent_rev": "bdefc4f71c8dd8dcd4b53d9adb2600c8574630bb", "commit_rev":
"69e032ada751d14f68658812ab90883bd7fabbc4"}

[commit-bot: I haz the power, 2017-06-07 19:00:47]

Description was changed from

==========
touch ui: Do not hide text selection handles when screen is rotated.

The text selection handles currently disappear when the device is rotated in
tablet mode.

TEST=manual
BUG=476320
==========

to

==========
touch ui: Do not hide text selection handles when screen is rotated.

The text selection handles currently disappear when the device is rotated in
tablet mode.

TEST=manual
BUG=476320

Review-Url: https://codereview.chromium.org/2924893002
Cr-Commit-Position: refs/heads/master@{#477716}
Committed:
https://chromium.googlesource.com/chromium/src/+/69e032ada751d14f68658812ab90...
==========

[commit-bot: I haz the power, 2017-06-07 19:00:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/69e032ada751d14f68658812ab90...