Propagate window transformed notification to child hierarchy

Propagate window transformed notification to child hierarchy

BUG=407659
Committed: https://crrev.com/14b6864a1a647bd7915b245050c81b13e280b145
Cr-Commit-Position: refs/heads/master@{#294235}

[mohsen, 2014-09-10 14:36:53]

mohsen@chromium.org changed reviewers:
+ sky@chromium.org

[mohsen, 2014-09-10 14:36:54]

Please take a look...

(This is only for Transformed notification. Do we need to add Transforming
notification, too?)

[sky, 2014-09-10 15:13:27]

https://codereview.chromium.org/558203002/diff/20001/ui/aura/window_observer.h
File ui/aura/window_observer.h (right):

https://codereview.chromium.org/558203002/diff/20001/ui/aura/window_observer....
ui/aura/window_observer.h:88: virtual void OnAncestorWindowTransformed(Window*
window, Window* ancestor) {}
Can you swap the order of these and rename ancestor to source?

[mohsen, 2014-09-10 15:48:59]

https://codereview.chromium.org/558203002/diff/20001/ui/aura/window_observer.h
File ui/aura/window_observer.h (right):

https://codereview.chromium.org/558203002/diff/20001/ui/aura/window_observer....
ui/aura/window_observer.h:88: virtual void OnAncestorWindowTransformed(Window*
window, Window* ancestor) {}
On 2014/09/10 15:13:27, sky wrote:
> Can you swap the order of these and rename ancestor to source?

Done.

[sky, 2014-09-10 16:10:47]

LGTM

https://codereview.chromium.org/558203002/diff/40001/ui/aura/window_unittest.cc
File ui/aura/window_unittest.cc (right):

https://codereview.chromium.org/558203002/diff/40001/ui/aura/window_unittest....
ui/aura/window_unittest.cc:1897: EXPECT_EQ("",
TransformNotificationsAndClear());
nit: either "" -> std::string() or
EXPECT_TRUE(TransformNotificationsAndClear().empty())

[mohsen, 2014-09-10 19:18:05]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-09-10 19:19:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohsen@chromium.org/558203002/60001

[commit-bot: I haz the power, 2014-09-10 19:34:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 19:34:41]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[mohsen, 2014-09-10 21:04:59]

The CQ bit was checked by mohsen@chromium.org

[commit-bot: I haz the power, 2014-09-10 21:12:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mohsen@chromium.org/558203002/60001

[commit-bot: I haz the power, 2014-09-10 21:41:49]

Committed patchset #4 (id:60001) as ebb5f9df71c826b6ff353b7684b9006d9fd72dc6

[commit-bot: I haz the power, 2014-09-10 22:00:14]

Patchset 4 (id:??) landed as
https://crrev.com/14b6864a1a647bd7915b245050c81b13e280b145
Cr-Commit-Position: refs/heads/master@{#294235}