Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2928593002: VR: Improving UI colors and elements positioning (Closed)

Created:
3 years, 6 months ago by cjgrant
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

VR: Improving UI colors and elements positioning - Updated colors for normal, fullscreen and incognito mode. - Tilting the URL bar to face the user. - Updated content size to 800*533px. This required the increase of DPR from 1.2 to 1.4 to keep the sharpness of text. BUG=728147 Review-Url: https://codereview.chromium.org/2915483002 Cr-Original-Commit-Position: refs/heads/master@{#476798} Review-Url: https://codereview.chromium.org/2928593002 . Cr-Commit-Position: refs/branch-heads/3112@{#182} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/6bf3fd87d28eaa2554bce23eb14fd34797527a25

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 1 chunk +25 lines, -22 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cjgrant
3 years, 6 months ago (2017-06-06 14:30:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bf3fd87d28eaa2554bce23eb14fd34797527a25.

Powered by Google App Engine
This is Rietveld 408576698