chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc - Issue 2928593002: VR: Improving UI colors and elements positioning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

Issue 2928593002: VR: Improving UI colors and elements positioning (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc ('k') | chrome/browser/android/vr_shell/ui_scene_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

diff --git a/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc b/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

index c89c31020514940e915a373aefdf4453b0248262..80d73a23f7c42de68a995e30e8acc6d3e67bb5d8 100644

--- a/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

+++ b/chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc

@@ -22,15 +22,17 @@ using security_state::SecurityLevel;

namespace vr_shell {

+// TODO(cjgrant): Use ColorScheme instead of hardcoded values

+// where it makes sense.

static const SkColor kEmphasizedColor = 0xFF000000;

static const SkColor kDeemphasizedColor = 0xFF5A5A5A;

static const SkColor kSecureColor = gfx::kGoogleGreen700;

static const SkColor kWarningColor = gfx::kGoogleRed700;

-static const SkColor kIncognitoDeemphasizedColor = 0xFFE6E6E6;

-static const SkColor kIncognitoEmphasizedColor = 0xFFFFFFFF;

-static const SkColor kIncognitoSecureColor = 0xFFE6E6E6;

-static const SkColor kIncognitoWarningColor = 0xFFE6E6E6;

+static const SkColor kIncognitoDeemphasizedColor = 0xFF878787;

+static const SkColor kIncognitoEmphasizedColor = 0xFFEDEDED;

+static const SkColor kIncognitoSecureColor = 0xFFEDEDED;

+static const SkColor kIncognitoWarningColor = 0xFFEDEDED;

static constexpr int kUrlWidth = 400;

static constexpr int kUrlHeight = 30;