Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2915483002: VR: Improving UI colors and elements positioning (Closed)

Created:
3 years, 6 months ago by acondor_
Modified:
3 years, 6 months ago
Reviewers:
mthiesse, amp
CC:
chromium-reviews, feature-vr-reviews_chromium.org, cjgrant
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Improving UI colors and elements positioning - Updated colors for normal, fullscreen and incognito mode. - Tilting the URL bar to face the user. - Updated content size to 800*533px. This required the increase of DPR from 1.2 to 1.4 to keep the sharpness of text. BUG=728147 Review-Url: https://codereview.chromium.org/2915483002 Cr-Commit-Position: refs/heads/master@{#476798} Committed: https://chromium.googlesource.com/chromium/src/+/af9e620d3dff0161d3dc9f8ef3607dfff69ca315

Patch Set 1 #

Patch Set 2 : separator color update #

Patch Set 3 : colors and positioning #

Patch Set 4 : new screen resolution & darker normal mode #

Patch Set 5 : incognito #

Patch Set 6 : rebase #

Patch Set 7 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/color_scheme.cc View 1 2 3 4 1 chunk +25 lines, -22 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/loading_indicator_texture.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc View 1 2 3 4 5 6 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/android/vr_shell/ui_scene_manager.cc View 1 2 3 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
acondor_
PTAL
3 years, 6 months ago (2017-06-02 17:21:42 UTC) #4
amp
lgtm Make sure to update the description, it still says WIP (looks like you updated ...
3 years, 6 months ago (2017-06-02 17:33:21 UTC) #6
acondor_
On 2017/06/02 17:33:21, amp wrote: > lgtm > > Make sure to update the description, ...
3 years, 6 months ago (2017-06-02 17:39:22 UTC) #8
mthiesse
lgtm
3 years, 6 months ago (2017-06-02 17:50:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915483002/80001
3 years, 6 months ago (2017-06-02 17:50:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/224488) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-02 17:53:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915483002/100001
3 years, 6 months ago (2017-06-02 18:45:23 UTC) #16
acondor_
Leaving a TODO for you on tests.
3 years, 6 months ago (2017-06-02 19:46:04 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2915483002/120001
3 years, 6 months ago (2017-06-02 19:46:59 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 21:31:55 UTC) #23
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/af9e620d3dff0161d3dc9f8ef360...

Powered by Google App Engine
This is Rietveld 408576698