Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 292763004: Revert of Gamepad API support for chrome on android (Closed)

Created:
6 years, 7 months ago by Kibeom Kim (inactive)
Modified:
6 years, 7 months ago
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Revert of Gamepad API support for chrome on android (https://codereview.chromium.org/133943002/) Reason for revert: This is failing on ICS because InputDeviceListener is API 16. Please fix it and resubmit :). (e.g., API guarding like in ApiCompatibilityUtils.java) Original issue's description: > Gamepad API support for chrome on android > > This change adds code to get gamepad data from java objects and > provide these updates to the GamepadProvider which then writes to > GamepadHardwareBuffer which in turn is read by SharedMemoryReader and > later returned by JS to the web page. > > Added singleton class GamepadsReader which is responsible for > communication with java class and accessing gamepad data. It adds > methods for communication with singleton java GamepadList class to > get gamepads data. > > This also adds new framework classes/methods required for Gamepad API > support. Frameworks changes are responsible for : > - Identifying gamepad devices and their capabilities. > - Managing connected gamepad devices > - Map the connected gamepad devices to standard Gamepad format. > - Keeping gamepads axes/buttons data up-to-date and returning it to > native whenever requested. In android we cannot get gamepad data > directly from sources, so framework is modified to capture > gamepad key and motion events and extract gamepad data from these > events. > > * Class GamepadPlatformDataFetcherAndroid : Android specific > implementation of gamepad data fetcher. > > * Class ContentViewCore : Manages gamepad list and notifies of new > key/motion event for gamepads. > > * Class GamepadList : A new class to manage connected gamepad devices > > * Class GamepadDevice : A new class to manage information related to > each gamepad device. > > * Class GamepadMappings : This class is responsible for mapping of > known gamepads to the standard gamepad. > > This change enables gamepad API by default. > > Adds support for parsing float array return type in JNI generator. > > NVIDIA Shield and XBox360 gamepads are mapped to the standard gamepad > > BUG=330094 > > TEST=http://www.html5rocks.com/en/tutorials/doodles/gamepad/gamepad-tester/tester.html > > R=tsepez@chromium.org > R=darin@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -897 lines) Patch
M android_webview/Android.mk View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/android_webview.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/jni_generator/jni_generator.py View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D content/browser/gamepad/canonical_axis_index_list.h View 1 chunk +0 lines, -16 lines 0 comments Download
D content/browser/gamepad/canonical_button_index_list.h View 1 chunk +0 lines, -28 lines 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher.h View 2 chunks +2 lines, -8 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_android.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/gamepad/gamepad_platform_data_fetcher_android.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M content/browser/gamepad/gamepad_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content.gyp View 2 chunks +0 lines, -17 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 5 chunks +0 lines, -5 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/CanonicalAxisIndex.template View 1 chunk +0 lines, -10 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/CanonicalButtonIndex.template View 1 chunk +0 lines, -10 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/GamepadDevice.java View 1 chunk +0 lines, -166 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/GamepadList.java View 1 chunk +0 lines, -302 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/GamepadMappings.java View 1 chunk +0 lines, -134 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Kibeom Kim (inactive)
6 years, 7 months ago (2014-05-19 18:49:51 UTC) #1
Created Revert of Gamepad API support for chrome on android

Powered by Google App Engine
This is Rietveld 408576698