[Snowflake] Unify bookmarks, history and downloads text styles

[Snowflake] Unify bookmarks, history and downloads text styles

+ Change history time stamp and urls to 54% black
+ Change default text color from #333 to 87% black

BUG=723050
Review-Url: https://codereview.chromium.org/2927603002
Cr-Commit-Position: refs/heads/master@{#477351}
Committed: https://chromium.googlesource.com/chromium/src/+/c64920be23861a50acda753f3984d94fac2ec7e3

[huayinz, 2017-06-06 17:01:50]

huayinz@chromium.org changed reviewers:
+ twellington@chromium.org

[huayinz, 2017-06-06 17:01:50]

twellington@ - Hi, could you take a look? Thanks!

[Theresa, 2017-06-06 17:08:50]

Looks good overall

https://codereview.chromium.org/2927603002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2927603002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/colors.xml:8: <color
name="default_text_color">@color/black_alpha_87</color>
I think this falls under: "Change all #343434 and #444 and #333 to Material
Primary Grey 600 - 87% black - #DE000000  (except in the toolbar/omnibox)"


Contextual search is also listed as an exception in the "unique type treatment"
section. 

Based on a quick code search, the omnibox, autofill and contextual search all
define separate #333 styles, but it would be good to do a quick test.

[huayinz, 2017-06-06 17:35:01]

https://codereview.chromium.org/2927603002/diff/1/chrome/android/java/res/val...
File chrome/android/java/res/values/colors.xml (right):

https://codereview.chromium.org/2927603002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/colors.xml:8: <color
name="default_text_color">@color/black_alpha_87</color>
On 2017/06/06 17:08:50, Theresa wrote:
> I think this falls under: "Change all #343434 and #444 and #333 to Material
> Primary Grey 600 - 87% black - #DE000000  (except in the toolbar/omnibox)"
> 
> 
> Contextual search is also listed as an exception in the "unique type
treatment"
> section. 
> 
> Based on a quick code search, the omnibox, autofill and contextual search all
> define separate #333 styles, but it would be good to do a quick test.

Done.

https://codereview.chromium.org/2927603002/diff/1/chrome/android/java/res/val...
chrome/android/java/res/values/colors.xml:8: <color
name="default_text_color">@color/black_alpha_87</color>
On 2017/06/06 17:08:50, Theresa wrote:
> I think this falls under: "Change all #343434 and #444 and #333 to Material
> Primary Grey 600 - 87% black - #DE000000  (except in the toolbar/omnibox)"
> 
> 
> Contextual search is also listed as an exception in the "unique type
treatment"
> section. 
> 
> Based on a quick code search, the omnibox, autofill and contextual search all
> define separate #333 styles, but it would be good to do a quick test.

Right, it doesn't affect omnibox, toolbar, and contextual search's color. I did
a code search and also change color to red then eyeball what gets changed:)

[Theresa, 2017-06-06 17:35:43]

lgtm

[huayinz, 2017-06-06 17:42:39]

The CQ bit was checked by huayinz@chromium.org

[commit-bot: I haz the power, 2017-06-06 17:43:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 18:39:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496770959754650, "parent_rev":
"c15b61bdf8133f14d7f715ee6e0dcc5ab65db57c", "commit_rev":
"c64920be23861a50acda753f3984d94fac2ec7e3"}

[commit-bot: I haz the power, 2017-06-06 18:39:44]

Description was changed from

==========
[Snowflake] Unify bookmarks, history and downloads text styles

+ Change history time stamp and urls to 54% black
+ Change default text color from #333 to 87% black

BUG=723050
==========

to

==========
[Snowflake] Unify bookmarks, history and downloads text styles

+ Change history time stamp and urls to 54% black
+ Change default text color from #333 to 87% black

BUG=723050

Review-Url: https://codereview.chromium.org/2927603002
Cr-Commit-Position: refs/heads/master@{#477351}
Committed:
https://chromium.googlesource.com/chromium/src/+/c64920be23861a50acda753f3984...
==========

[commit-bot: I haz the power, 2017-06-06 18:39:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c64920be23861a50acda753f3984...

[huayinz, 2017-06-06 20:52:03]

Patchset #2 (id:20001) has been deleted