Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2927603002: [Snowflake] Unify bookmarks, history and downloads text styles (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources xmlns:tools="http://schemas.android.com/tools"> 6 <resources xmlns:tools="http://schemas.android.com/tools">
7 <!-- Q: Why put style resources under values-v17/ ? 7 <!-- Q: Why put style resources under values-v17/ ?
8 A: Problem: 8 A: Problem:
9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339. 9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert 10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 <item name="android:textSize">12sp</item> 628 <item name="android:textSize">12sp</item>
629 <item name="android:ellipsize">start</item> 629 <item name="android:ellipsize">start</item>
630 <item name="android:singleLine">true</item> 630 <item name="android:singleLine">true</item>
631 </style> 631 </style>
632 <style name="DateView" parent="RobotoMediumStyle"> 632 <style name="DateView" parent="RobotoMediumStyle">
633 <item name="android:layout_width">match_parent</item> 633 <item name="android:layout_width">match_parent</item>
634 <item name="android:layout_height">wrap_content</item> 634 <item name="android:layout_height">wrap_content</item>
635 <item name="android:layout_marginTop">12dp</item> 635 <item name="android:layout_marginTop">12dp</item>
636 <item name="android:layout_marginBottom">10dp</item> 636 <item name="android:layout_marginBottom">10dp</item>
637 <item name="android:textSize">14sp</item> 637 <item name="android:textSize">14sp</item>
638 <item name="android:textColor">@color/black_alpha_54</item>
638 </style> 639 </style>
639 <style name="DownloadRowContainer"> 640 <style name="DownloadRowContainer">
640 <item name="android:layout_width">match_parent</item> 641 <item name="android:layout_width">match_parent</item>
641 <item name="android:layout_height">wrap_content</item> 642 <item name="android:layout_height">wrap_content</item>
642 <item name="android:layout_marginStart">16dp</item> 643 <item name="android:layout_marginStart">16dp</item>
643 <item name="android:layout_marginTop">16dp</item> 644 <item name="android:layout_marginTop">16dp</item>
644 <item name="android:layout_marginBottom">16dp</item> 645 <item name="android:layout_marginBottom">16dp</item>
645 <item name="android:gravity">center_vertical</item> 646 <item name="android:gravity">center_vertical</item>
646 <item name="android:orientation">horizontal</item> 647 <item name="android:orientation">horizontal</item>
647 </style> 648 </style>
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 <item name="android:padding">16dp</item> 725 <item name="android:padding">16dp</item>
725 </style> 726 </style>
726 727
727 <!-- Photo Picker animations --> 728 <!-- Photo Picker animations -->
728 729
729 <style name="PhotoPickerDialogAnimation"> 730 <style name="PhotoPickerDialogAnimation">
730 <item name="android:windowEnterAnimation">@anim/design_bottom_sheet_slid e_in</item> 731 <item name="android:windowEnterAnimation">@anim/design_bottom_sheet_slid e_in</item>
731 <item name="android:windowExitAnimation">@null</item> 732 <item name="android:windowExitAnimation">@null</item>
732 </style> 733 </style>
733 </resources> 734 </resources>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698