chrome/android/java/res/values/colors.xml - Issue 2927603002: [Snowflake] Unify bookmarks, history and downloads text styles

Side by Side Diff: chrome/android/java/res/values/colors.xml

Issue 2927603002: [Snowflake] Unify bookmarks, history and downloads text styles (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/android/java/res/values-v17/styles.xml ('k') | no next file » | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources>	6 <resources>

7 <!-- Common colors -->	7 <!-- Common colors -->

8 <color name="default_text_color">#333</color>	8 <color name="default_text_color">@color/black_alpha_87</color>
	Theresa 2017/06/06 17:08:50 I think this falls under: "Change all #343434 and I think this falls under: "Change all #343434 and #444 and #333 to Material Primary Grey 600 - 87% black - #DE000000 (except in the toolbar/omnibox)" Contextual search is also listed as an exception in the "unique type treatment" section. Based on a quick code search, the omnibox, autofill and contextual search all define separate #333 styles, but it would be good to do a quick test. huayinz 2017/06/06 17:35:01 Done. Show quoted text On 2017/06/06 17:08:50, Theresa wrote: > I think this falls under: "Change all #343434 and #444 and #333 to Material > Primary Grey 600 - 87% black - #DE000000 (except in the toolbar/omnibox)" > > > Contextual search is also listed as an exception in the "unique type treatment" > section. > > Based on a quick code search, the omnibox, autofill and contextual search all > define separate #333 styles, but it would be good to do a quick test. Done. huayinz 2017/06/06 17:35:01 Right, it doesn't affect omnibox, toolbar, and con Show quoted text On 2017/06/06 17:08:50, Theresa wrote: > I think this falls under: "Change all #343434 and #444 and #333 to Material > Primary Grey 600 - 87% black - #DE000000 (except in the toolbar/omnibox)" > > > Contextual search is also listed as an exception in the "unique type treatment" > section. > > Based on a quick code search, the omnibox, autofill and contextual search all > define separate #333 styles, but it would be good to do a quick test. Right, it doesn't affect omnibox, toolbar, and contextual search's color. I did a code search and also change color to red then eyeball what gets changed:)
9 <color name="default_primary_color">#f2f2f2</color>	9 <color name="default_primary_color">#f2f2f2</color>

10 <color name="light_normal_color">#5A5A5A</color>	10 <color name="light_normal_color">#5A5A5A</color>

11 <color name="light_active_color">#4285F4</color>	11 <color name="light_active_color">#4285F4</color>

12 <color name="input_underline_error_color">#d32f2f</color>	12 <color name="input_underline_error_color">#d32f2f</color>

13 <color name="explanation_text_color">#909090</color>	13 <color name="explanation_text_color">#909090</color>

14 <color name="text_highlight_color">#C6DAFC</color>	14 <color name="text_highlight_color">#C6DAFC</color>

15 <color name="dark_action_bar_color">#263238</color>	15 <color name="dark_action_bar_color">#263238</color>

16 <color name="descriptive_text_color">#646464</color>	16 <color name="descriptive_text_color">#646464</color>

17 <color name="error_text_color">#c53929</color>	17 <color name="error_text_color">#c53929</color>

18 <color name="google_blue_200">#90caf9</color>	18 <color name="google_blue_200">#90caf9</color>

(...skipping 199 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
218	218

219 <!-- Translate Infobar colors -->	219 <!-- Translate Infobar colors -->

220 <color name="translate_overflow_menu_divider_color">#e0e0e0</color>	220 <color name="translate_overflow_menu_divider_color">#e0e0e0</color>

221	221

222 <!-- Other colors -->	222 <!-- Other colors -->

223 <color name="selectable_list_item_highlight_color">#804281f4</color>	223 <color name="selectable_list_item_highlight_color">#804281f4</color>

224 <color name="media_viewer_bg">#000000</color>	224 <color name="media_viewer_bg">#000000</color>

225 <color name="image_viewer_bg">#0e0e0e</color>	225 <color name="image_viewer_bg">#0e0e0e</color>

226	226

227 </resources>	227 </resources>

OLD	NEW