Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2927583002: Revert of Explictly setting story names for rasterize_and_record_micro story sets (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, vmpstr
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Explictly setting story names for rasterize_and_record_micro story sets (patchset #1 id:1 of https://codereview.chromium.org/2921333002/ ) Reason for revert: key_silk_cases has a few names in the form 'file://key_silk_cases/inbox_app.html?swipe_to_dismiss' which should be 'inbox_app.html?swipe_to_dismiss' instead Original issue's description: > Explictly setting story names for rasterize_and_record_micro story sets > > BUG=chromium:720002 > > Review-Url: https://codereview.chromium.org/2921333002 > Cr-Commit-Position: refs/heads/master@{#477290} > Committed: https://chromium.googlesource.com/chromium/src/+/0f8c781859c2e2767a543d0238870c105a0ece88 TBR=vmpstr@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2927583002 Cr-Commit-Position: refs/heads/master@{#477302} Committed: https://chromium.googlesource.com/chromium/src/+/db86d7ee45310334b962959f4eafce7348a17b36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M tools/perf/page_sets/key_mobile_sites.py View 2 chunks +1 line, -4 lines 0 comments Download
M tools/perf/page_sets/key_mobile_sites_pages.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/perf/page_sets/partial_invalidation_cases.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/perf/page_sets/top_25_pages.py View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/perf/page_sets/top_pages.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ashleymarie1
Created Revert of Explictly setting story names for rasterize_and_record_micro story sets
3 years, 6 months ago (2017-06-06 15:52:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927583002/1
3 years, 6 months ago (2017-06-06 15:52:30 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-06 15:52:33 UTC) #5
nednguyen
lgtm
3 years, 6 months ago (2017-06-06 15:53:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927583002/1
3 years, 6 months ago (2017-06-06 15:53:39 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 15:54:12 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db86d7ee45310334b962959f4eaf...

Powered by Google App Engine
This is Rietveld 408576698