Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: tools/perf/page_sets/key_silk_cases.py

Issue 2927583002: Revert of Explictly setting story names for rasterize_and_record_micro story sets (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import shared_page_state 5 from telemetry.page import shared_page_state
6 from telemetry import story 6 from telemetry import story
7 7
8 8
9 class KeySilkCasesPage(page_module.Page): 9 class KeySilkCasesPage(page_module.Page):
10 10
11 def __init__(self, url, page_set, run_no_page_interactions): 11 def __init__(self, url, page_set, run_no_page_interactions):
12 """ Base class for all key silk cases pages. 12 """ Base class for all key silk cases pages.
13 13
14 Args: 14 Args:
15 run_no_page_interactions: whether the page will run any interactions after 15 run_no_page_interactions: whether the page will run any interactions after
16 navigate steps. 16 navigate steps.
17 """ 17 """
18 super(KeySilkCasesPage, self).__init__( 18 super(KeySilkCasesPage, self).__init__(
19 url=url, page_set=page_set, credentials_path = 'data/credentials.json', 19 url=url, page_set=page_set, credentials_path = 'data/credentials.json',
20 shared_page_state_class=shared_page_state.SharedMobilePageState, 20 shared_page_state_class=shared_page_state.SharedMobilePageState)
21 name=url)
22 self.archive_data_file = 'data/key_silk_cases.json' 21 self.archive_data_file = 'data/key_silk_cases.json'
23 self._run_no_page_interactions = run_no_page_interactions 22 self._run_no_page_interactions = run_no_page_interactions
24 23
25 def RunNavigateSteps(self, action_runner): 24 def RunNavigateSteps(self, action_runner):
26 super(KeySilkCasesPage, self).RunNavigateSteps(action_runner) 25 super(KeySilkCasesPage, self).RunNavigateSteps(action_runner)
27 action_runner.Wait(2) 26 action_runner.Wait(2)
28 27
29 def RunPageInteractions(self, action_runner): 28 def RunPageInteractions(self, action_runner):
30 # If a key silk case page wants to customize it actions, it should 29 # If a key silk case page wants to customize it actions, it should
31 # overrides the PerformPageInteractions method instead of this method. 30 # overrides the PerformPageInteractions method instead of this method.
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 action_runner.WaitForJavaScriptCondition('window.done') 716 action_runner.WaitForJavaScriptCondition('window.done')
718 717
719 718
720 class KeySilkCasesPageSet(story.StorySet): 719 class KeySilkCasesPageSet(story.StorySet):
721 720
722 """ Pages hand-picked for project Silk. """ 721 """ Pages hand-picked for project Silk. """
723 722
724 def __init__(self, run_no_page_interactions=False): 723 def __init__(self, run_no_page_interactions=False):
725 super(KeySilkCasesPageSet, self).__init__( 724 super(KeySilkCasesPageSet, self).__init__(
726 archive_data_file='data/key_silk_cases.json', 725 archive_data_file='data/key_silk_cases.json',
727 cloud_storage_bucket=story.PARTNER_BUCKET, 726 cloud_storage_bucket=story.PARTNER_BUCKET)
728 verify_names=True)
729 727
730 self.AddStory(Page1(self, run_no_page_interactions)) 728 self.AddStory(Page1(self, run_no_page_interactions))
731 self.AddStory(Page2(self, run_no_page_interactions)) 729 self.AddStory(Page2(self, run_no_page_interactions))
732 self.AddStory(Page3(self, run_no_page_interactions)) 730 self.AddStory(Page3(self, run_no_page_interactions))
733 self.AddStory(Page4(self, run_no_page_interactions)) 731 self.AddStory(Page4(self, run_no_page_interactions))
734 self.AddStory(Page5(self, run_no_page_interactions)) 732 self.AddStory(Page5(self, run_no_page_interactions))
735 self.AddStory(Page6(self, run_no_page_interactions)) 733 self.AddStory(Page6(self, run_no_page_interactions))
736 self.AddStory(Page7(self, run_no_page_interactions)) 734 self.AddStory(Page7(self, run_no_page_interactions))
737 self.AddStory(Page8(self, run_no_page_interactions)) 735 self.AddStory(Page8(self, run_no_page_interactions))
738 self.AddStory(Page9(self, run_no_page_interactions)) 736 self.AddStory(Page9(self, run_no_page_interactions))
(...skipping 22 matching lines...) Expand all
761 self.AddStory(SilkFinance(self, run_no_page_interactions)) 759 self.AddStory(SilkFinance(self, run_no_page_interactions))
762 # Flaky interaction steps on Android; crbug.com/507865 760 # Flaky interaction steps on Android; crbug.com/507865
763 # self.AddStory(PolymerTopeka(self, run_no_page_interactions)) 761 # self.AddStory(PolymerTopeka(self, run_no_page_interactions))
764 self.AddStory(Masonry(self, run_no_page_interactions)) 762 self.AddStory(Masonry(self, run_no_page_interactions))
765 763
766 for page in self: 764 for page in self:
767 assert (page.__class__.RunPageInteractions == 765 assert (page.__class__.RunPageInteractions ==
768 KeySilkCasesPage.RunPageInteractions), ( 766 KeySilkCasesPage.RunPageInteractions), (
769 'Pages in this page set must not override KeySilkCasesPage\' ' 767 'Pages in this page set must not override KeySilkCasesPage\' '
770 'RunPageInteractions method.') 768 'RunPageInteractions method.')
OLDNEW
« no previous file with comments | « tools/perf/page_sets/key_mobile_sites_pages.py ('k') | tools/perf/page_sets/partial_invalidation_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698