Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2921333002: Explictly setting story names for rasterize_and_record_micro story sets (Closed)

Created:
3 years, 6 months ago by ashleymarie1
Modified:
3 years, 6 months ago
Reviewers:
nednguyen, vmpstr
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Explictly setting story names for rasterize_and_record_micro story sets BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2921333002 Cr-Original-Commit-Position: refs/heads/master@{#477290} Committed: https://chromium.googlesource.com/chromium/src/+/0f8c781859c2e2767a543d0238870c105a0ece88 Review-Url: https://codereview.chromium.org/2921333002 Cr-Commit-Position: refs/heads/master@{#477369} Committed: https://chromium.googlesource.com/chromium/src/+/500f75b2f92268e040cd4cd3bb69f827d95ba6ea

Patch Set 1 #

Patch Set 2 : Fixing key_silks_Cases #

Patch Set 3 : Explictly setting story names for rasterize_and_record_micro story sets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M tools/perf/page_sets/key_mobile_sites.py View 2 chunks +4 lines, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_pages.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/page_sets/key_silk_cases.py View 1 2 chunks +7 lines, -2 lines 0 comments Download
M tools/perf/page_sets/partial_invalidation_cases.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/polymer.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_25_pages.py View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/perf/page_sets/top_pages.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
ashleymarie1
3 years, 6 months ago (2017-06-05 20:00:45 UTC) #2
nednguyen
lgtm
3 years, 6 months ago (2017-06-05 20:01:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921333002/1
3 years, 6 months ago (2017-06-05 20:01:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/310870)
3 years, 6 months ago (2017-06-06 00:41:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921333002/1
3 years, 6 months ago (2017-06-06 13:18:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0f8c781859c2e2767a543d0238870c105a0ece88
3 years, 6 months ago (2017-06-06 15:16:29 UTC) #12
ashleymarie1
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2927583002/ by ashleymarie@chromium.org. ...
3 years, 6 months ago (2017-06-06 15:52:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921333002/40001
3 years, 6 months ago (2017-06-06 16:54:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921333002/40001
3 years, 6 months ago (2017-06-06 17:36:34 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-06 19:24:27 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/500f75b2f92268e040cd4cd3bb69...

Powered by Google App Engine
This is Rietveld 408576698