[vpython] Fix PEP425 naming.

[vpython] Fix PEP425 naming.

Early choices resulted in some incorrect naming of PEP425 structure
fields. Fix this before "vpython" is used in too many places to make
fixing this feasible.

The "Pep425Tag" Protobuf struct is now named "PEP425Tag" so that its
Go-generated structure is more idiomatic. This has no impact on the text
or binary protobuf format.

The fields in a "Pep425Tag" have been renamed from "Version, ABI, Arch"
to the proper "Python, ABI, Platform" terminology used in PEP425. This
will break existing text protobuf naming, so we have updated the
protobuf version from "v1" to "v2".

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2927573002
Committed: https://github.com/luci/luci-go/commit/0a455fedda06056a0be820f951c16655b3420899

[dnj, 2017-06-06 14:25:36]

dnj@chromium.org changed reviewers:
+ dnj@chromium.org, iannucci@chromium.org, qyearsley@chromium.org

[dnj, 2017-06-06 14:25:36]

PTAL. This addresses a problem that qyearsley@ pointed out in a previous code
review, namely that the PEP425Tag struct doesn't use PEP425 field names.

The reason for this is legacy - it used to be a generic wheel field expression,
and that spec didn't have strong naming guidelines for its field. However, now
that it's formally a PEP425Tag, it should match.

This will impact (AFAICT) exactly one thing: the recipe engine VirtualEnv spec
text protobuf. Since that's pinned within the recipe engine, we can fix that and
update the pin in a single go.

I think it's best to land/roll this before we get too many things using the
previous text protobuf terminology.

[qyearsley, 2017-06-06 14:33:32]

LGTM

https://codereview.chromium.org/2927573002/diff/1/vpython/api/vpython/pep425....
File vpython/api/vpython/pep425.proto (right):

https://codereview.chromium.org/2927573002/diff/1/vpython/api/vpython/pep425....
vpython/api/vpython/pep425.proto:9: // Represnets a Python PEP425 tag.
Unrelated typo on this line.

https://codereview.chromium.org/2927573002/diff/1/vpython/api/vpython/pep425....
vpython/api/vpython/pep425.proto:11: // Version is the PEP425 python tag (e.g.,
"cp27").
This comment should be updated too.

https://codereview.chromium.org/2927573002/diff/1/vpython/cipd/pep425.go
File vpython/cipd/pep425.go (right):

https://codereview.chromium.org/2927573002/diff/1/vpython/cipd/pep425.go#newc...
vpython/cipd/pep425.go:16: // If the platform could not be determined, an empoty
string will be returned.
Another little typo unrelated to this CL ("empty") could be fixed here as well.

[dnj, 2017-06-06 19:32:51]

iannucci@, ping?

[dnj (Google), 2017-06-06 19:34:47]

typos

[dnj, 2017-06-06 19:34:50]

https://codereview.chromium.org/2927573002/diff/1/vpython/api/vpython/pep425....
File vpython/api/vpython/pep425.proto (right):

https://codereview.chromium.org/2927573002/diff/1/vpython/api/vpython/pep425....
vpython/api/vpython/pep425.proto:9: // Represnets a Python PEP425 tag.
On 2017/06/06 14:33:32, qyearsley wrote:
> Unrelated typo on this line.

Done.

https://codereview.chromium.org/2927573002/diff/1/vpython/api/vpython/pep425....
vpython/api/vpython/pep425.proto:11: // Version is the PEP425 python tag (e.g.,
"cp27").
On 2017/06/06 14:33:32, qyearsley wrote:
> This comment should be updated too.

Done.

https://codereview.chromium.org/2927573002/diff/1/vpython/cipd/pep425.go
File vpython/cipd/pep425.go (right):

https://codereview.chromium.org/2927573002/diff/1/vpython/cipd/pep425.go#newc...
vpython/cipd/pep425.go:16: // If the platform could not be determined, an empoty
string will be returned.
On 2017/06/06 14:33:32, qyearsley wrote:
> Another little typo unrelated to this CL ("empty") could be fixed here as
well.

Done.

[dnj (Google), 2017-06-07 18:59:44]

rebase and update

[dnj, 2017-06-07 19:01:33]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-06-07 19:01:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2927573002/#ps40001
(title: "rebase and update")

[commit-bot: I haz the power, 2017-06-07 19:01:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 19:07:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496862093616040,
"parent_rev": "288831e8f27616792594ba30104b6266ba9af015", "commit_rev":
"0a455fedda06056a0be820f951c16655b3420899"}

[commit-bot: I haz the power, 2017-06-07 19:07:26]

Description was changed from

==========
[vpython] Fix PEP425 naming.

Early choices resulted in some incorrect naming of PEP425 structure
fields. Fix this before "vpython" is used in too many places to make
fixing this feasible.

The "Pep425Tag" Protobuf struct is now named "PEP425Tag" so that its
Go-generated structure is more idiomatic. This has no impact on the text
or binary protobuf format.

The fields in a "Pep425Tag" have been renamed from "Version, ABI, Arch"
to the proper "Python, ABI, Platform" terminology used in PEP425. This
will break existing text protobuf naming, so we have updated the
protobuf version from "v1" to "v2".

BUG=None
TEST=local
==========

to

==========
[vpython] Fix PEP425 naming.

Early choices resulted in some incorrect naming of PEP425 structure
fields. Fix this before "vpython" is used in too many places to make
fixing this feasible.

The "Pep425Tag" Protobuf struct is now named "PEP425Tag" so that its
Go-generated structure is more idiomatic. This has no impact on the text
or binary protobuf format.

The fields in a "Pep425Tag" have been renamed from "Version, ABI, Arch"
to the proper "Python, ABI, Platform" terminology used in PEP425. This
will break existing text protobuf naming, so we have updated the
protobuf version from "v1" to "v2".

BUG=None
TEST=local

Review-Url: https://codereview.chromium.org/2927573002
Committed:
https://github.com/luci/luci-go/commit/0a455fedda06056a0be820f951c16655b3420899
==========

[commit-bot: I haz the power, 2017-06-07 19:07:27]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/0a455fedda06056a0be820f951c16655b3420899