Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: vpython/spec/spec.go

Issue 2927573002: [vpython] Fix PEP425 naming. (Closed)
Patch Set: rebase and update Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vpython/spec/match_test.go ('k') | vpython/spec/spec_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vpython/spec/spec.go
diff --git a/vpython/spec/spec.go b/vpython/spec/spec.go
index 1f8fa80f4cabbe1196e289baa2257e79504c6f0e..a675f3263d15173df10a03d462725142ce397b29 100644
--- a/vpython/spec/spec.go
+++ b/vpython/spec/spec.go
@@ -44,7 +44,7 @@ func NormalizeEnvironment(env *vpython.Environment) error {
//
// NormalizeSpec will prune any Wheel entries that don't match the specified
// tags, and will remove the match entries from any remaining Wheel entries.
-func NormalizeSpec(spec *vpython.Spec, tags []*vpython.Pep425Tag) error {
+func NormalizeSpec(spec *vpython.Spec, tags []*vpython.PEP425Tag) error {
if spec.Virtualenv != nil && len(spec.Virtualenv.MatchTag) > 0 {
// The VirtualEnv package may not specify a match tag.
spec.Virtualenv.MatchTag = nil
@@ -124,15 +124,15 @@ func (s specPackageSlice) Less(i, j int) bool {
}.Use(i, j)
}
-type pep425TagSlice []*vpython.Pep425Tag
+type pep425TagSlice []*vpython.PEP425Tag
func (s pep425TagSlice) Len() int { return len(s) }
func (s pep425TagSlice) Swap(i, j int) { s[i], s[j] = s[j], s[i] }
func (s pep425TagSlice) Less(i, j int) bool {
return sortby.Chain{
- func(i, j int) bool { return s[i].Version < s[j].Version },
+ func(i, j int) bool { return s[i].Python < s[j].Python },
func(i, j int) bool { return s[i].Abi < s[j].Abi },
- func(i, j int) bool { return s[i].Arch < s[j].Arch },
+ func(i, j int) bool { return s[i].Platform < s[j].Platform },
}.Use(i, j)
}
« no previous file with comments | « vpython/spec/match_test.go ('k') | vpython/spec/spec_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698