Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: vpython/venv/venv.go

Issue 2927573002: [vpython] Fix PEP425 naming. (Closed)
Patch Set: rebase and update Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vpython/spec/spec_test.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vpython/venv/venv.go
diff --git a/vpython/venv/venv.go b/vpython/venv/venv.go
index 2e27fe8cf68483f84afd3de30eb7e56cbe73902a..0ff764e46035106023f7ce2184829ece1ceca5b7 100644
--- a/vpython/venv/venv.go
+++ b/vpython/venv/venv.go
@@ -566,7 +566,7 @@ func (e *Env) installVirtualEnv(c context.Context, pkgDir string) error {
// getPEP425Tags calls Python's pip.pep425tags package to retrieve the tags.
//
// This must be run while "pip" is installed in the VirtualEnv.
-func (e *Env) getPEP425Tags(c context.Context) ([]*vpython.Pep425Tag, error) {
+func (e *Env) getPEP425Tags(c context.Context) ([]*vpython.PEP425Tag, error) {
// This script will return a list of 3-entry lists:
// [0]: version (e.g., "cp27")
// [1]: abi (e.g., "cp27mu", "none")
@@ -594,7 +594,7 @@ func (e *Env) getPEP425Tags(c context.Context) ([]*vpython.Pep425Tag, error) {
Err()
}
- tags := make([]*vpython.Pep425Tag, len(tagEntries))
+ tags := make([]*vpython.PEP425Tag, len(tagEntries))
for i, te := range tagEntries {
if len(te) != 3 {
return nil, errors.Reason("invalid PEP425 tag entry: %(entry)v").
@@ -603,10 +603,10 @@ func (e *Env) getPEP425Tags(c context.Context) ([]*vpython.Pep425Tag, error) {
Err()
}
- tags[i] = &vpython.Pep425Tag{
- Version: te[0],
- Abi: te[1],
- Arch: te[2],
+ tags[i] = &vpython.PEP425Tag{
+ Python: te[0],
+ Abi: te[1],
+ Platform: te[2],
}
}
« no previous file with comments | « vpython/spec/spec_test.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698