Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2927223002: Revert of [ios] Disable WebResourceUtilTest due to risk of timeouts. (Closed)

Created:
3 years, 6 months ago by robliao
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ios] Disable WebResourceUtilTest due to risk of timeouts. (patchset #1 id:1 of https://codereview.chromium.org/2926133002/ ) Reason for revert: The underlying cause of http://crbug.com/728216 should be fixed. These tests should be good to go now. Original issue's description: > [ios] Disable WebResourceUtilTest due to risk of timeouts. > > crbug.com/728216 details an issue that could cause > ScopedTaskEnvironment::RunUntilIdle() to hang forever. This CL disables the > tests that have a chance of hanging until a fix is instituted. > > BUG=728216 > > Review-Url: https://codereview.chromium.org/2926133002 > Cr-Commit-Position: refs/heads/master@{#477654} > Committed: https://chromium.googlesource.com/chromium/src/+/88d6f53c69299ac5a899d64904fa795861817736 TBR=baxley@chromium.org,liaoyuke@chromium.org,rohitrao@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=728216 Review-Url: https://codereview.chromium.org/2927223002 Cr-Commit-Position: refs/heads/master@{#478126} Committed: https://chromium.googlesource.com/chromium/src/+/e8d7f36c67e1fc0d5f4b37682bc72c5be565a3ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M ios/chrome/browser/web_resource/web_resource_util_unittest.cc View 4 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
robliao
Created Revert of [ios] Disable WebResourceUtilTest due to risk of timeouts.
3 years, 6 months ago (2017-06-08 23:43:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927223002/1
3 years, 6 months ago (2017-06-08 23:43:40 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 23:58:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e8d7f36c67e1fc0d5f4b37682bc7...

Powered by Google App Engine
This is Rietveld 408576698