Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: ios/chrome/browser/web_resource/web_resource_util_unittest.cc

Issue 2927223002: Revert of [ios] Disable WebResourceUtilTest due to risk of timeouts. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web_resource/web_resource_util_unittest.cc
diff --git a/ios/chrome/browser/web_resource/web_resource_util_unittest.cc b/ios/chrome/browser/web_resource/web_resource_util_unittest.cc
index c9fc90144c526824a2eb88f00b9965f1afbec524..ac1950a8a94f99e9b4fbc6ed8a0faa805d86eab4 100644
--- a/ios/chrome/browser/web_resource/web_resource_util_unittest.cc
+++ b/ios/chrome/browser/web_resource/web_resource_util_unittest.cc
@@ -61,9 +61,7 @@
bool success_called_;
};
-// TODO(crbug.com/728216): Disabled because
-// ScopedTaskEnvironment::RunUntilIdle() may hang.
-TEST_F(WebResourceUtilTest, DISABLED_Success) {
+TEST_F(WebResourceUtilTest, Success) {
const std::string kExpectedKey("foo");
const std::string kExpectedValue("bar");
std::string json = base::StringPrintf("{\"%s\":\"%s\"}", kExpectedKey.c_str(),
@@ -87,10 +85,8 @@
EXPECT_EQ(kExpectedValue, actual_value_as_string);
}
-// Only DictionaryValues are expected.
-// TODO(crbug.com/728216): Disabled because
-// ScopedTaskEnvironment::RunUntilIdle() may hang.
-TEST_F(WebResourceUtilTest, DISABLED_UnexpectedValue) {
+// Only DictionartValues are expected.
+TEST_F(WebResourceUtilTest, UnexpectedValue) {
GetIOSChromeParseJSONCallback().Run("foo", GetSuccessCallback(),
GetErrorCallback());
@@ -103,9 +99,7 @@
}
// Empty data is not expected.
-// TODO(crbug.com/728216): Disabled because
-// ScopedTaskEnvironment::RunUntilIdle() may hang.
-TEST_F(WebResourceUtilTest, DISABLED_EmptyValue) {
+TEST_F(WebResourceUtilTest, EmptyValue) {
GetIOSChromeParseJSONCallback().Run(std::string(), GetSuccessCallback(),
GetErrorCallback());
@@ -118,9 +112,7 @@
}
// Wrong syntax.
-// TODO(crbug.com/728216): Disabled because
-// ScopedTaskEnvironment::RunUntilIdle() may hang.
-TEST_F(WebResourceUtilTest, DISABLED_SyntaxError) {
+TEST_F(WebResourceUtilTest, SyntaxError) {
GetIOSChromeParseJSONCallback().Run("%$[", GetSuccessCallback(),
GetErrorCallback());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698