Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2926133002: [ios] Disable WebResourceUtilTest due to risk of timeouts. (Closed)

Created:
3 years, 6 months ago by rohitrao (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
*baxley, liaoyuke, robliao
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Disable WebResourceUtilTest due to risk of timeouts. crbug.com/728216 details an issue that could cause ScopedTaskEnvironment::RunUntilIdle() to hang forever. This CL disables the tests that have a chance of hanging until a fix is instituted. BUG=728216 Review-Url: https://codereview.chromium.org/2926133002 Cr-Commit-Position: refs/heads/master@{#477654} Committed: https://chromium.googlesource.com/chromium/src/+/88d6f53c69299ac5a899d64904fa795861817736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M ios/chrome/browser/web_resource/web_resource_util_unittest.cc View 4 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
rohitrao (ping after 24h)
3 years, 6 months ago (2017-06-07 15:03:05 UTC) #3
baxley
lgtm
3 years, 6 months ago (2017-06-07 15:07:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2926133002/1
3 years, 6 months ago (2017-06-07 15:18:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/88d6f53c69299ac5a899d64904fa795861817736
3 years, 6 months ago (2017-06-07 15:23:46 UTC) #13
robliao
3 years, 6 months ago (2017-06-08 23:43:08 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2927223002/ by robliao@chromium.org.

The reason for reverting is: The underlying cause of http://crbug.com/728216
should be fixed. These tests should be good to go now..

Powered by Google App Engine
This is Rietveld 408576698