Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2927213002: [MD settings] I18nBehavior return textContent from i18n() (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, stevenjb
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] I18nBehavior return textContent from i18n() This CL removes a prior quick-fix that swapped   for \u00a0 and instead returns the textContent from i18n(). The result (as mentioned in the updated comments) is that i18n() should be used for non-HTML and i18nAdvanced() should be used for innerHTML. BUG=731289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2927213002 Cr-Commit-Position: refs/heads/master@{#479197} Committed: https://chromium.googlesource.com/chromium/src/+/08ca8daa7508aa661025291b66b50609687c3033

Patch Set 1 : closure fix #

Total comments: 4

Patch Set 2 : review changes #

Patch Set 3 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M chrome/browser/resources/md_user_manager/create_profile.js View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_create_confirm.js View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.js View 2 chunks +15 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/android_apps_page/android_apps_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/extension_controlled_indicator.js View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/test/data/webui/i18n_behavior_test.html View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/js/i18n_behavior.js View 1 2 3 chunks +23 lines, -16 lines 0 comments Download

Messages

Total messages: 30 (25 generated)
dschuyler
3 years, 6 months ago (2017-06-08 22:55:34 UTC) #14
Dan Beam
lgtm https://codereview.chromium.org/2927213002/diff/40001/chrome/test/data/webui/i18n_behavior_test.html File chrome/test/data/webui/i18n_behavior_test.html (right): https://codereview.chromium.org/2927213002/diff/40001/chrome/test/data/webui/i18n_behavior_test.html#newcode7 chrome/test/data/webui/i18n_behavior_test.html:7: * --gtest_filter='WebUIResourceBrowserTest.I18nBehaviorTest'. */ these instructions are not useful. ...
3 years, 6 months ago (2017-06-08 23:21:41 UTC) #15
dschuyler
https://codereview.chromium.org/2927213002/diff/40001/chrome/test/data/webui/i18n_behavior_test.html File chrome/test/data/webui/i18n_behavior_test.html (right): https://codereview.chromium.org/2927213002/diff/40001/chrome/test/data/webui/i18n_behavior_test.html#newcode7 chrome/test/data/webui/i18n_behavior_test.html:7: * --gtest_filter='WebUIResourceBrowserTest.I18nBehaviorTest'. */ On 2017/06/08 23:21:41, Dan Beam wrote: ...
3 years, 6 months ago (2017-06-09 00:13:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2927213002/60001
3 years, 6 months ago (2017-06-13 20:46:23 UTC) #27
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 23:12:16 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/08ca8daa7508aa661025291b66b5...

Powered by Google App Engine
This is Rietveld 408576698