chrome/browser/resources/settings/controls/extension_controlled_indicator.js - Issue 2927213002: [MD settings] I18nBehavior return textContent from i18n()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/controls/extension_controlled_indicator.js

Issue 2927213002: [MD settings] I18nBehavior return textContent from i18n() (Closed)

Patch Set: merge with master Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/android_apps_page/android_apps_page.html ('k') | chrome/test/data/webui/i18n_behavior_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/controls/extension_controlled_indicator.js

diff --git a/chrome/browser/resources/settings/controls/extension_controlled_indicator.js b/chrome/browser/resources/settings/controls/extension_controlled_indicator.js

index a5737c901137db7b07def943f341526c88ca46f5..71feaafe052dede432c96d7d17930baa4a16a8cb 100644

--- a/chrome/browser/resources/settings/controls/extension_controlled_indicator.js

+++ b/chrome/browser/resources/settings/controls/extension_controlled_indicator.js

@@ -21,9 +21,11 @@ Polymer({

getLabel_: function(extensionId, extensionName) {

var manageUrl = 'chrome://extensions/?id=' + assert(this.extensionId);

- return this.i18n('controlledByExtension',

- '<a href="' + manageUrl + '" target="_blank">' +

- assert(this.extensionName) + '</a>');

+ return this.i18nAdvanced('controlledByExtension', {

+ substitutions:

+ ['<a href="' + manageUrl + '" target="_blank">' +

+ assert(this.extensionName) + '</a>'],

+ });

/** @private */