chrome/test/data/webui/i18n_behavior_test.html - Issue 2927213002: [MD settings] I18nBehavior return textContent from i18n() - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(5704)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/test/data/webui/i18n_behavior_test.html

Issue 2927213002: [MD settings] I18nBehavior return textContent from i18n() (Closed)

Patch Set: merge with master Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/resources/settings/controls/extension_controlled_indicator.js ('k') | ui/webui/resources/js/i18n_behavior.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/i18n_behavior_test.html

diff --git a/chrome/test/data/webui/i18n_behavior_test.html b/chrome/test/data/webui/i18n_behavior_test.html

index e79ef725ce107f2583368287722beea3b6f916c3..fca9944c24f12e2a15faf44c2077dc5a3360c080 100644

--- a/chrome/test/data/webui/i18n_behavior_test.html

+++ b/chrome/test/data/webui/i18n_behavior_test.html

@@ -3,8 +3,6 @@

<body>

<script>

-/* Execute these tests with the browser_tests executable. */

-

var allowedByDefault = '<a href="https://google.com">Google!</a>';

var text = 'I\'m just text, nobody should have a problem with me!';

var nonBreakingSpace = 'A\u00a0B\u00a0C'; // \u00a0 is a unicode nbsp.

@@ -22,7 +20,6 @@ function setUpPage() {

}

function testI18n() {

- assertEquals(allowedByDefault, I18nBehavior.i18n('allowedByDefault'));

assertEquals(text, I18nBehavior.i18n('text'));

assertEquals(nonBreakingSpace, I18nBehavior.i18n('nonBreakingSpace'));

@@ -33,6 +30,9 @@ function testI18n() {

}

function testI18nAdvanced() {

+ assertEquals(

+ allowedByDefault,

+ I18nBehavior.i18nAdvanced('allowedByDefault'));

I18nBehavior.i18nAdvanced('customAttr', {

attrs: {

is: function(el, val) {

« no previous file with comments | « chrome/browser/resources/settings/controls/extension_controlled_indicator.js ('k') | ui/webui/resources/js/i18n_behavior.js » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698