Split DirectCompositionSurfaceWin into two parts.

Split DirectCompositionSurfaceWin into two parts.

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926763002
Cr-Commit-Position: refs/heads/master@{#478794}
Committed: https://chromium.googlesource.com/chromium/src/+/196982d4d2cb3b3d2b3f0a6a432c2176e11110ec

[jbauman, 2017-06-07 01:30:07]

Description was changed from

==========
Split DirectCompositionSurfaceWin into two parts.

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
==========

to

==========
Split DirectCompositionSurfaceWin into two parts.

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-06-07 01:30:12]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 01:30:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 02:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 02:52:12]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-06-07 22:08:17]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 22:08:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 23:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 23:45:55]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-06-07 23:50:01]

jbauman@chromium.org changed reviewers:
+ sunnyps@chromium.org

[sunnyps, 2017-06-10 00:11:11]

lgtm % nits

https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
File gpu/ipc/service/direct_composition_child_surface_win.cc (right):

https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
gpu/ipc/service/direct_composition_child_surface_win.cc:41: class
ScopedReleaseCurrent {
nit: This is duplicated both here and in the root surface. Can you move this to
ui/gl/scoped_make_current.h?

https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
File gpu/ipc/service/direct_composition_surface_win.cc (right):

https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
gpu/ipc/service/direct_composition_surface_win.cc:1094: return
RecreateRootSurface();
nit: This seems like a change in behavior if multiple Resize calls happen.
Previously, we'd only recreate the root surface on the first draw after the
resize but now it's on every resize. Same with SetEnableDCLayers, though that
would probably be called far less frequently.

[jbauman, 2017-06-10 00:47:32]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-10 00:47:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 00:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 00:55:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_headless_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jbauman, 2017-06-10 00:58:58]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-10 00:59:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-10 02:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-10 02:17:53]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[jbauman, 2017-06-12 20:10:55]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 20:12:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-06-12 20:41:22]

On 2017/06/10 00:11:11, sunnyps wrote:
> lgtm % nits
> 
>
https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
> File gpu/ipc/service/direct_composition_child_surface_win.cc (right):
> 
>
https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
> gpu/ipc/service/direct_composition_child_surface_win.cc:41: class
> ScopedReleaseCurrent {
> nit: This is duplicated both here and in the root surface. Can you move this
to
> ui/gl/scoped_make_current.h?
> 
>
https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
> File gpu/ipc/service/direct_composition_surface_win.cc (right):
> 
>
https://codereview.chromium.org/2926763002/diff/20001/gpu/ipc/service/direct_...
> gpu/ipc/service/direct_composition_surface_win.cc:1094: return
> RecreateRootSurface();
> nit: This seems like a change in behavior if multiple Resize calls happen.
> Previously, we'd only recreate the root surface on the first draw after the
> resize but now it's on every resize. Same with SetEnableDCLayers, though that
> would probably be called far less frequently.

The actual DirectComposition surface is only created on SetDrawRectangle. This
just creates a new DirectCompositionSurfaceWin (and 1x1 EGL pbuffer, which
should be cheap).

[commit-bot: I haz the power, 2017-06-12 22:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 22:29:40]

Dry run: This issue passed the CQ dry run.

[jbauman, 2017-06-12 22:31:02]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2017-06-12 22:31:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sunnyps@chromium.org
Link to the patchset: https://codereview.chromium.org/2926763002/#ps80001
(title: "add disallow copy and assign")

[commit-bot: I haz the power, 2017-06-12 22:31:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 22:36:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497306662766330,
"parent_rev": "7dd8521be01b568b6b2df7ef14f9787a3def7ea5", "commit_rev":
"196982d4d2cb3b3d2b3f0a6a432c2176e11110ec"}

[commit-bot: I haz the power, 2017-06-12 22:37:04]

Description was changed from

==========
Split DirectCompositionSurfaceWin into two parts.

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Split DirectCompositionSurfaceWin into two parts.

DirectCompositionSurfaceWin remains as the host of the DCLayerTree,
while DirectCompositionChildSurfaceWin handles drawing to the
IDCompositionSurface itself. This will allow us to have more Surfaces
in the layer tree in the future.

BUG=726957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2926763002
Cr-Commit-Position: refs/heads/master@{#478794}
Committed:
https://chromium.googlesource.com/chromium/src/+/196982d4d2cb3b3d2b3f0a6a432c...
==========

[commit-bot: I haz the power, 2017-06-12 22:37:06]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/196982d4d2cb3b3d2b3f0a6a432c...