[CrOS Tether] Create proto_test_util.cc/h and move CreateTestDeviceStatus() there.

[CrOS Tether] Create proto_test_util.cc/h and move CreateTestDeviceStatus() there.

This CL consolidates all usages of similar functions and prepares for https://codereview.chromium.org/2918863002/ to use the function as well.

BUG=672263
Review-Url: https://codereview.chromium.org/2926503002
Cr-Commit-Position: refs/heads/master@{#477151}
Committed: https://chromium.googlesource.com/chromium/src/+/cd63c6d5d540c3790721212e4670500835dac8f5

[Kyle Horimoto, 2017-06-05 21:36:58]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org

[Ryan Hansberry, 2017-06-05 22:52:23]

lgtm

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/message_wrapper_unittest.cc (right):

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
chromeos/components/tether/message_wrapper_unittest.cc:23: DeviceStatus
CreateFakeDeviceStatus() {
This same method without any args is across about 4 files. Can you please place
it in proto_test_utils as an additional helper method?

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/proto_test_util.cc (right):

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
chromeos/components/tether/proto_test_util.cc:19: wifi_status.set_ssid("Google
A");
nit: use a non-Google specific string, e.g. "WifiSsid"

[Kyle Horimoto, 2017-06-05 23:18:56]

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/message_wrapper_unittest.cc (right):

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
chromeos/components/tether/message_wrapper_unittest.cc:23: DeviceStatus
CreateFakeDeviceStatus() {
On 2017/06/05 22:52:23, Ryan Hansberry wrote:
> This same method without any args is across about 4 files. Can you please
place
> it in proto_test_utils as an additional helper method?

Done.

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
File chromeos/components/tether/proto_test_util.cc (right):

https://codereview.chromium.org/2926503002/diff/1/chromeos/components/tether/...
chromeos/components/tether/proto_test_util.cc:19: wifi_status.set_ssid("Google
A");
On 2017/06/05 22:52:23, Ryan Hansberry wrote:
> nit: use a non-Google specific string, e.g. "WifiSsid"

Done.

[Kyle Horimoto, 2017-06-05 23:19:00]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2017-06-05 23:19:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
hansberry@chromium.org
Link to the patchset: https://codereview.chromium.org/2926503002/#ps20001
(title: "hansberry@ comment.")

[commit-bot: I haz the power, 2017-06-05 23:19:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 23:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 23:26:20]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Kyle Horimoto, 2017-06-05 23:33:06]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2017-06-05 23:33:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
hansberry@chromium.org
Link to the patchset: https://codereview.chromium.org/2926503002/#ps40001
(title: "Included missing dep.")

[commit-bot: I haz the power, 2017-06-05 23:33:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 01:50:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496705586239130,
"parent_rev": "2c5eae86eddc741f7619898863ab70d89a29f39e", "commit_rev":
"cd63c6d5d540c3790721212e4670500835dac8f5"}

[commit-bot: I haz the power, 2017-06-06 01:50:16]

Description was changed from

==========
[CrOS Tether] Create proto_test_util.cc/h and move CreateTestDeviceStatus()
there.

This CL consolidates all usages of similar functions and prepares for
https://codereview.chromium.org/2918863002/ to use the function as well.

BUG=672263
==========

to

==========
[CrOS Tether] Create proto_test_util.cc/h and move CreateTestDeviceStatus()
there.

This CL consolidates all usages of similar functions and prepares for
https://codereview.chromium.org/2918863002/ to use the function as well.

BUG=672263

Review-Url: https://codereview.chromium.org/2926503002
Cr-Commit-Position: refs/heads/master@{#477151}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd63c6d5d540c3790721212e4670...
==========

[commit-bot: I haz the power, 2017-06-06 01:50:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd63c6d5d540c3790721212e4670...