[CrOS Tether] Create proto_test_util.cc/h and move CreateTestDeviceStatus() there.

chromeos/components/tether/host_scanner_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/components/tether/host_scanner.h"
 
 #include <algorithm>
 #include <memory>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/test/scoped_task_environment.h"
 #include "base/test/simple_test_clock.h"
 #include "base/time/time.h"
 #include "chromeos/components/tether/device_id_tether_network_guid_map.h"
 #include "chromeos/components/tether/fake_ble_connection_manager.h"
 #include "chromeos/components/tether/fake_host_scan_cache.h"
 #include "chromeos/components/tether/fake_notification_presenter.h"
 #include "chromeos/components/tether/fake_tether_host_fetcher.h"
 #include "chromeos/components/tether/host_scan_device_prioritizer.h"
 #include "chromeos/components/tether/host_scanner.h"
 #include "chromeos/components/tether/mock_tether_host_response_recorder.h"
+#include "chromeos/components/tether/proto_test_util.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "components/cryptauth/remote_device_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 namespace tether {
 
 namespace {
 
@@ skipping 70 matching lines @@
   const std::vector<cryptauth::RemoteDevice>& expected_devices_;
   std::vector<FakeHostScannerOperation*> created_operations_;
 };
 
 std::string GenerateCellProviderForDevice(
     const cryptauth::RemoteDevice& remote_device) {
   // Return a string unique to |remote_device|.
   return "cellProvider" + remote_device.GetTruncatedDeviceIdForLogs();
 }
 
-const char kDoNotSetStringField[] = "doNotSetField";
-const int kDoNotSetIntField = -100;
-
-// Creates a DeviceStatus object using the parameters provided. If
-// |kDoNotSetStringField| or |kDoNotSetIntField| are passed, these fields will
-// not be set in the output.
-DeviceStatus CreateFakeDeviceStatus(const std::string& cell_provider_name,
-                                    int battery_percentage,
-                                    int connection_strength) {
-  // TODO(khorimoto): Once a ConnectedWifiSsid field is added as a property of
-  // Tether networks, give an option to pass a parameter for that field as well.
-  WifiStatus wifi_status;
-  wifi_status.set_status_code(
-      WifiStatus_StatusCode::WifiStatus_StatusCode_CONNECTED);
-  wifi_status.set_ssid("Google A");
-
-  DeviceStatus device_status;
-  if (battery_percentage != kDoNotSetIntField) {
-    device_status.set_battery_percentage(battery_percentage);
-  }
-  if (cell_provider_name != kDoNotSetStringField) {
-    device_status.set_cell_provider(cell_provider_name);
-  }
-  if (connection_strength != kDoNotSetIntField) {
-    device_status.set_connection_strength(connection_strength);
-  }
-
-  device_status.mutable_wifi_status()->CopyFrom(wifi_status);
-
-  return device_status;
-}
-
 std::vector<HostScannerOperation::ScannedDeviceInfo>
 CreateFakeScannedDeviceInfos(
     const std::vector<cryptauth::RemoteDevice>& remote_devices) {
   // At least 4 ScannedDeviceInfos should be created to ensure that all 4 cases
   // described below are tested.
   EXPECT_GT(remote_devices.size(), 3u);
 
   std::vector<HostScannerOperation::ScannedDeviceInfo> scanned_device_infos;
 
   for (size_t i = 0; i < remote_devices.size(); ++i) {
     // Four field possibilities:
     // i % 4 == 0: Field is not supplied.
     // i % 4 == 1: Field is below the minimum value (int fields only).
     // i % 4 == 2: Field is within the valid range (int fields only).
     // i % 4 == 3: Field is above the maximium value (int fields only).
     std::string cell_provider_name;
     int battery_percentage;
     int connection_strength;
     switch (i % 4) {
       case 0:
-        cell_provider_name = kDoNotSetStringField;
-        battery_percentage = kDoNotSetIntField;
-        connection_strength = kDoNotSetIntField;
+        cell_provider_name = proto_test_util::kDoNotSetStringField;
+        battery_percentage = proto_test_util::kDoNotSetIntField;
+        connection_strength = proto_test_util::kDoNotSetIntField;
         break;
       case 1:
         cell_provider_name = GenerateCellProviderForDevice(remote_devices[i]);
         battery_percentage = -1 - i;
         connection_strength = -1 - i;
         break;
       case 2:
         cell_provider_name = GenerateCellProviderForDevice(remote_devices[i]);
         battery_percentage = (50 + i) % 100;  // Valid range is [0, 100].
         connection_strength = (1 + i) % 4;    // Valid range is [0, 4].
         break;
       case 3:
         cell_provider_name = GenerateCellProviderForDevice(remote_devices[i]);
         battery_percentage = 101 + i;
         connection_strength = 101 + i;
         break;
       default:
         NOTREACHED();
         // Set values for |battery_percentage| and |connection_strength| here to
         // prevent a compiler warning which says that they may be unset at this
         // point.
         battery_percentage = 0;
         connection_strength = 0;
         break;
     }
 
-    DeviceStatus device_status = CreateFakeDeviceStatus(
+    DeviceStatus device_status = CreateTestDeviceStatus(
         cell_provider_name, battery_percentage, connection_strength);
 
     // Require set-up for odd-numbered device indices.
     bool setup_required = i % 2 == 0;
 
     scanned_device_infos.push_back(HostScannerOperation::ScannedDeviceInfo(
         remote_devices[i], device_status, setup_required));
   }
 
   return scanned_device_infos;
@@ skipping 391 matching lines @@
   EXPECT_TRUE(host_scanner_->HasRecentlyScanned());
 
   // Move past the limit.
   test_clock_->Advance(base::TimeDelta::FromSeconds(1));
   EXPECT_FALSE(host_scanner_->HasRecentlyScanned());
 }
 
 }  // namespace tether
 
 }  // namespace chromeos